Skip to contentSkip to conversation

gitweb: Fix thinko in git_tags and git_heads

PATCH New Jakub Narebski 1 participant 1 message Jun 15, 2016

lore
Share & tools
lore

Jakub Narebski

author
#0 lore raw

PATCH 1/1 gitweb: Fix thinko in git_tags and git_heads

git_get_refs_list always return reference to list (and reference to hash which we ignore), so $taglist (in git_tags) and $headlist (in git_heads) are always defined, but @$taglist / @$headlist might be empty. Replaced incorrect "if (defined @$taglist)" with "if (@$taglist)" in git_tags and respectively in git_heads.

Signed-off-by Jakub Narebski <[email protected]>
---
 gitweb/gitweb.perl |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
gitweb/gitweb.perl +2 -2
index 34311ee..9445fa7 100755
@@ -2565,7 +2565,7 @@ sub git_tags {
 	git_print_header_div('summary', $project);
 
 	my ($taglist) = git_get_refs_list("tags");
-	if (defined @$taglist) {
+	if (@$taglist) {
 		git_tags_body($taglist);
 	}
 	git_footer_html();

@@ -2578,7 +2578,7 @@ sub git_heads {
 	git_print_header_div('summary', $project);
 
 	my ($headlist) = git_get_refs_list("heads");
-	if (defined @$headlist) {
+	if (@$headlist) {
 		git_heads_body($headlist, $head);
 	}
 	git_footer_html();
Signature · 1 line
1.4.2.1