Skip to contentSkip to conversation

stir4200: removing undocumented bits handling

PATCH Applied Samuel Ortiz 2 participants 2 messages Sep 19, 2006 – Sep 28, 2006 1 message not in the archive

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Samuel Ortiz

author
#0 lore raw

PATCH 3/3 stir4200: removing undocumented bits handling

FIFOCTL_RXERR and FIFOCTL_TXERR are undocumented bits, according to the Sigmatel datasheet. We should thus not take any assumption on their values and semantics.

Problem spotted by andrzej zaborowski <[email protected]>

Signed-off-by Samuel Ortiz <[email protected]>
---
 drivers/net/irda/stir4200.c |   15 ---------------
 1 files changed, 0 insertions(+), 15 deletions(-)
drivers/net/irda/stir4200.c +0 -15
index d61b208..12103c9 100644
@@ -149,8 +149,6 @@ enum StirFifoCtlMask {
 	FIFOCTL_DIR = 0x10,
 	FIFOCTL_CLR = 0x08,
 	FIFOCTL_EMPTY = 0x04,
-	FIFOCTL_RXERR = 0x02,
-	FIFOCTL_TXERR = 0x01,
 };
 
 enum StirDiagMask {

@@ -615,19 +613,6 @@ static int fifo_txwait(struct stir_cb *s
 
 		pr_debug("fifo status 0x%lx count %lu\n", status, count);
 
-		/* error when receive/transmit fifo gets confused */
-		if (status & FIFOCTL_RXERR) {
-			stir->stats.rx_fifo_errors++;
-			stir->stats.rx_errors++;
-			break;
-		}
-
-		if (status & FIFOCTL_TXERR) {
-			stir->stats.tx_fifo_errors++;
-			stir->stats.tx_errors++;
-			break;
-		}
-
 		/* is fifo receiving already, or empty */
 		if (!(status & FIFOCTL_DIR)
 		    || (status & FIFOCTL_EMPTY))
Signature · 1 line
1.4.1.1

A message that is not in the archive (sent off-list or not yet received): [email protected]

Applied
#2 lore raw

From: Samuel Ortiz <[email protected]>
Date: Wed, 20 Sep 2006 08:09:24 +0300

Quoted 6 lines

FIFOCTL_RXERR and FIFOCTL_TXERR are undocumented bits, according to the Sigmatel datasheet. We should thus not take any assumption on their values and semantics.

Problem spotted by andrzej zaborowski <[email protected]>

Signed-off-by Samuel Ortiz <[email protected]>

Applied, thanks.

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV