Skip to contentSkip to conversation

ams: remove usage of input_dev cdev

PATCH In review Aristeu Sergio Rozanski Filho 3 participants 3 messages Sep 21, 2006 Hardware monitoring

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ams: remove usage of input_dev cdev

This patch removes usage of 'cdev' member of input_dev, not present on that struct anymore.

drivers/hwmon/ams/ams-mouse.c +0 -1
@@ -66,7 +66,6 @@
 	ams_info.idev->name = "Apple Motion Sensor";
 	ams_info.idev->id.bustype = ams_info.bustype;
 	ams_info.idev->id.vendor = 0;
-	ams_info.idev->cdev.dev = &ams_info.of_dev->dev;
 
 	input_set_abs_params(ams_info.idev, ABS_X, -50, 50, 3, 0);
 	input_set_abs_params(ams_info.idev, ABS_Y, -50, 50, 3, 0);
#1 lore raw
Quoted 3 lines · Aristeu Sergio Rozanski Filho

This patch removes usage of 'cdev' member of input_dev, not present on that struct anymore.

Where did it go?

Quoted 13 lines
drivers/hwmon/ams/ams-mouse.c +0 -1
@@ -66,7 +66,6 @@
 	ams_info.idev->name = "Apple Motion Sensor";
 	ams_info.idev->id.bustype = ams_info.bustype;
 	ams_info.idev->id.vendor = 0;
-	ams_info.idev->cdev.dev = &ams_info.of_dev->dev;
 
 	input_set_abs_params(ams_info.idev, ABS_X, -50, 50, 3, 0);
 	input_set_abs_params(ams_info.idev, ABS_Y, -50, 50, 3, 0);
Signature · 1 line
Dmitry
#2 lore raw
Quoted 6 lines · On Wed, 20 Sep 2006 21:59:53 -0400 Dmitry Torokhov <[email protected]> wrote:
Quoted 3 lines · Aristeu Sergio Rozanski Filho

This patch removes usage of 'cdev' member of input_dev, not present on that struct anymore.

Where did it go?

Sigh. That would make a good ./.signature

Quoted 10 lines
Quoted 10 lines
drivers/hwmon/ams/ams-mouse.c +0 -1
@@ -66,7 +66,6 @@
 	ams_info.idev->name = "Apple Motion Sensor";
 	ams_info.idev->id.bustype = ams_info.bustype;
 	ams_info.idev->id.vendor = 0;
-	ams_info.idev->cdev.dev = &ams_info.of_dev->dev;
 
Quoted 3 lines

drivers/hwmon/ams/ams-mouse.c line 71

Quoted 3 lines
drivers/hwmon/ams/ams-mouse.c +0 -0
 	input_set_abs_params(ams_info.idev, ABS_X, -50, 50, 3, 0);
 	input_set_abs_params(ams_info.idev, ABS_Y, -50, 50, 3, 0);

I think the right fix is s/cdev.dev/d.parent/g. But Greg has moved all those patches out of the tree which I'll henceforth be merging into -mm, so we can stop worrying about it.