Skip to contentSkip to conversation

NFS: Manage NFS modularity vs FS-Cache modularity

PATCH In review David Howells 2 participants 5 messages Sep 22, 2006 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 NFS: Manage NFS modularity vs FS-Cache modularity

Manage NFS modularity vs FS-Cache modularity such that NFS doesn't have the option to use the cache if NFS is built in and FS-Cache is a module.

---

 fs/Kconfig |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
fs/Kconfig +2 -1
index afec7e1..77cc578 100644
@@ -1507,7 +1507,8 @@ config NFS_V4
 
 config NFS_FSCACHE
 	bool "Provide NFS client caching support (EXPERIMENTAL)"
-	depends on NFS_FS && FSCACHE && EXPERIMENTAL
+	depends on EXPERIMENTAL
+	depends on NFS_FS=m && FSCACHE || NFS_FS=y && FSCACHE=y
 	help
 	  Say Y here if you want NFS data to be cached locally on disc through
 	  the general filesystem cache manager
#1 lore raw

PATCH 2/2 AFS: Manage AFS modularity vs FS-Cache modularity

Manage AFS modularity vs FS-Cache modularity such that AFS doesn't have the option to use the cache if AFS is built in and FS-Cache is a module.

---

 fs/Kconfig |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
fs/Kconfig +2 -1
index 77cc578..25d2019 100644
@@ -1952,7 +1952,8 @@ # for fs/nls/Config.in
 
 config AFS_FSCACHE
 	bool "Provide AFS client caching support"
-	depends on AFS_FS && FSCACHE && EXPERIMENTAL
+	depends on EXPERIMENTAL
+	depends on AFS_FS=m && FSCACHE || AFS_FS=y && FSCACHE=y
 	help
 	  Say Y here if you want AFS data to be cached locally on through the
 	  generic filesystem cache manager
#2 lore raw

Re: [PATCH 2/2] AFS: Manage AFS modularity vs FS-Cache modularity

Quoted 2 lines · David Howells

bool "Provide AFS client caching support"

(EXPERIMENTAL) ?

fs/Kconfig # for fs/nls/Config.in · line 1958

Quoted 2 lines
fs/Kconfig +0 -1
-	depends on AFS_FS && FSCACHE && EXPERIMENTAL
 	  Say Y here if you want AFS data to be cached locally on through the

disk ?

At least I cannot see why the AFS patch differs from the NFS one in those two details.

Jörn

Signature · 4 lines
More computing sins are committed in the name of efficiency (without
necessarily achieving it) than for any other single reason - including
blind stupidity.
-- W. A. Wulf
#3 lore raw

Re: [PATCH 2/2] AFS: Manage AFS modularity vs FS-Cache modularity

Quoted 2 lines · Jörn Engel

At least I cannot see why the AFS patch differs from the NFS one in those two details.

Actually, what the patch itself changes doesn't differ significantly - the difference is in the patch context.

Quoted 2 lines
Quoted 1 line

bool "Provide AFS client caching support"

(EXPERIMENTAL) ?

Well, AFS_FS is itself marked as being experimental, so I'm not sure that the AFS_FSCACHE option needs to be also.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#4 lore raw

Re: [PATCH 2/2] AFS: Manage AFS modularity vs FS-Cache modularity

Quoted 3 lines · David Howells

Well, AFS_FS is itself marked as being experimental, so I'm not sure that the AFS_FSCACHE option needs to be also.

Good point. The other typo should be fairly obvious, though.

Jörn

Signature · 8 lines
Fancy algorithms are slow when n is small, and n is usually small.
Fancy algorithms have big constants. Until you know that n is
frequently going to be big, don't get fancy.
-- Rob Pike
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html