Skip to contentSkip to conversation

allow building out of tree (sort of)

PATCH In review Mike Frysinger 2 participants 3 messages Sep 22, 2006 – Sep 26, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 allow building out of tree (sort of)

the current configure script assumes that it will be run in the srcdir ... i often build things out of tree so you can quickly punt all the generated files:
mkdir build
cd build
../configure
cd ..
rm -r build
clean!

this tweaks the configure script in a few places to use the correct variable instead of assuming that configure is always in $PWD ...

i say "sort of" in the subject because there is still the issues of the pcm symbols list being generated in $builddir instead of $srcdir and the alsa include symlink, but these doesnt really concern me for what i need ;) -mike

 configure.in |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
configure.in +6 -6
diff -r 8bdd68608788 configure.in
@@ -83,7 +84,7 @@ AC_ARG_WITH(versioned,
   versioned="$withval", versioned="yes")
 if test "$versioned" = "yes"; then
   # it seems that GNU ld versions since 2.10 are not broken
-  xres=`grep '^VERSION=' $ac_aux_dir/libtool | cut -d = -f 2`
+  xres=`grep '^VERSION=' libtool | cut -d = -f 2`
   major=`echo $xres | cut -d . -f 1`
   minor=`echo $xres | cut -d . -f 2`
   pass=0
@@ -357,18 +368,18 @@ fi
 
 
 dnl Create PCM plugin symbol list for static library
-rm -f src/pcm/pcm_symbols_list.c
+rm -f "$srcdir"/src/pcm/pcm_symbols_list.c
 for t in $PCM_PLUGIN_LIST; do
   if eval test \$build_pcm_$t = yes; then
-    echo \&_snd_module_pcm_$t, >> src/pcm/pcm_symbols_list.c
+    echo \&_snd_module_pcm_$t, >> "$srcdir"/src/pcm/pcm_symbols_list.c
   fi
 done
 
 dnl Make a symlink for inclusion of alsa/xxx.h
-if test ! -L include/alsa ; then
+if test ! -L "$srcdir"/include/alsa ; then
   echo "Making a symlink include/alsa"
-  rm -f include/alsa
-  ln -sf . include/alsa
+  rm -f "$srcdir"/include/alsa
+  ln -sf . "$srcdir"/include/alsa
 fi
 
 AC_OUTPUT(Makefile doc/Makefile doc/pictures/Makefile include/Makefile

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

_______________________________________________
Alsa-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/alsa-devel

#1 lore raw

At Fri, 22 Sep 2006 17:24:35 -0400,

Quoted 12 lines · Mike Frysinger

[1.1 <text/plain; us-ascii (quoted-printable)>]
the current configure script assumes that it will be run in the srcdir ... i often build things out of tree so you can quickly punt all the generated files:
mkdir build
cd build
../configure
cd ..
rm -r build
clean!

Quoted 6 lines

this tweaks the configure script in a few places to use the correct variable instead of assuming that configure is always in $PWD ...

i say "sort of" in the subject because there is still the issues of the pcm symbols list being generated in $builddir instead of $srcdir and the alsa include symlink, but these doesnt really concern me for what i need ;)

Thanks, this looks OK but I'll apply it after 1.0.13 in this week release. Since we're in the last rc phase, I'd like to be 120% sure that nothing will be broken by the new change.

Other your three patches are fine and applied to HG tree now.

Takashi

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

#2 lore raw
Quoted 3 lines · Takashi Iwai

Thanks, this looks OK but I'll apply it after 1.0.13 in this week release. Since we're in the last rc phase, I'd like to be 120% sure that nothing will be broken by the new change.

no problem ... i'm not in a "need it in next release!" sort of phase :)

Quoted 1 line

Other your three patches are fine and applied to HG tree now.

thanks !
-mike

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

_______________________________________________
Alsa-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/alsa-devel