hwmon: Fix unchecked return status,
Subsystems (2)
PATCH 14/23 hwmon: Fix unchecked return status,
From: "Mark M. Hoffman" <mhoffman at lightlink.com>
Content-Disposition: inline; filename=hwmon-unchecked-return-status-fixes-3.patch
hwmon: Fix unchecked return status, batch 3
Fix up some hwmon drivers so that they no longer ignore return status from device_create_file().
Signed-off-by Mark M. Hoffman <mhoffman at lightlink.com>
Signed-off-by Jean Delvare <khali at linux-fr.org>
--- drivers/hwmon/adm1021.c | 31 ++++- drivers/hwmon/adm1025.c | 94 ++++++++++----- drivers/hwmon/adm1026.c | 286 ++++++++++++++++++++++++----------------------- drivers/hwmon/adm1031.c | 114 ++++++++++++------- drivers/hwmon/adm9240.c | 105 +++++++---------- 5 files changed, 346 insertions(+), 284 deletions(-)
drivers/hwmon/adm1021.c +22 -9
@@ -190,6 +190,21 @@return i2c_probe (adapter, &addr_data, adm1021_detect); } +static struct attribute *adm1021_attributes[] = { + &dev_attr_temp1_max.attr, + &dev_attr_temp1_min.attr, + &dev_attr_temp1_input.attr, + &dev_attr_temp2_max.attr, + &dev_attr_temp2_min.attr, + &dev_attr_temp2_input.attr, + &dev_attr_alarms.attr, +NULL +}; + +static const struct attribute_group adm1021_group = { + .attrs = adm1021_attributes, +}; +static int adm1021_detect (struct i2c_adapter *adapter,int address,int kind) {int i;
@@ -287,22 +302,19 @@adm1021_init_client (new_client);/* Register sysfs hooks */ +if ((err =sysfs_create_group (&new_client->dev.kobj, &adm1021_group))) + goto error2; + data->class_dev =hwmon_device_register (&new_client->dev);if (IS_ERR (data->class_dev)) { err =PTR_ERR (data->class_dev); - goto error2; + goto error3; } -device_create_file (&new_client->dev, &dev_attr_temp1_max); -device_create_file (&new_client->dev, &dev_attr_temp1_min); -device_create_file (&new_client->dev, &dev_attr_temp1_input); -device_create_file (&new_client->dev, &dev_attr_temp2_max); -device_create_file (&new_client->dev, &dev_attr_temp2_min); -device_create_file (&new_client->dev, &dev_attr_temp2_input); -device_create_file (&new_client->dev, &dev_attr_alarms); -return 0 ; +error3: +sysfs_remove_group (&new_client->dev.kobj, &adm1021_group); error2:i2c_detach_client (new_client); error1:
@@ -326,6 +338,7 @@int err;hwmon_device_unregister (data->class_dev); +sysfs_remove_group (&client->dev.kobj, &adm1021_group);if ((err =i2c_detach_client (client)))return err;
drivers/hwmon/adm1025.c +62 -32
120 lines not on this page · raw message
drivers/hwmon/adm1026.c +146 -140
318 lines not on this page · raw message
drivers/hwmon/adm1031.c +70 -44
139 lines not on this page · raw message
drivers/hwmon/adm9240.c +46 -59
130 lines not on this page · raw message
Signature · 1 line
Jean Delvare