Skip to contentSkip to conversation

monitor "info" command crashes qemu

PATCH New Juergen Keil 1 participant 1 message Sep 25, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 monitor "info" command crashes qemu

The monitor's "info" command crashes qemu on a Solaris host.

Apparently a NULL pointer is passed as argument for a "%s" printf format string.

The "info capture" command has a missing "params" string (help string is used as params structure member and help structure member is NULL).

And "info snapshots" has copied&pasted the buggy structure initializer.

Fix:

Index: monitor.c
===================================================================
RCS file: /cvsroot/qemu/qemu/monitor.c,v
retrieving revision 1.56

monitor.c 25 Sep 2006 08:05:58 -0000 renamed from monitor.c 5 Aug 2006 21:31:00 -0000 1.56 +2 -2
diff -u -B -r1.56 monitor.c
@@ -1230,9 +1230,9 @@
     { "profile", "", do_info_profile,
       "", "show profiling information", },
     { "capture", "", do_info_capture,
-      "show capture information" },
+      "", "show capture information" },
     { "snapshots", "", do_info_snapshots,
-      "show the currently saved VM snapshots" },
+      "", "show the currently saved VM snapshots" },
     { NULL, NULL, },
 };