ehea firmware interface based on Anton Blanchard's new hvcall interface
Subsystems (2)
PATCH 1/1 ehea firmware interface based on Anton Blanchard's new hvcall interface
Hello Jeff,
this eHEA patch reflects changes according to Anton's new hvcall interface which has been commited in Paul's git tree:
git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc.git
Thanks to this change our pHYP interface needs less lines of code. In addition to the above changes the patch includes a bug fix (port state notification) and minor changes (default queue length, coding style updates).
Thanks,
Jan-Bernd Themann
---
drivers/net/ehea/ehea.h | 13 - drivers/net/ehea/ehea_main.c | 12 drivers/net/ehea/ehea_phyp.c | 559 +++++++++++++++++-------------------------- 3 files changed, 244 insertions(+), 340 deletions(-)
drivers/net/ehea/ehea.h +7 -6
@@ -39,7 +39,7 @@#include <asm/io.h> #define DRV_NAME "ehea" -#define DRV_VERSION "EHEA_0028" +#define DRV_VERSION "EHEA_0033"#define EHEA_MSG_DEFAULT (NETIF_MSG_LINK | NETIF_MSG_TIMER \ | NETIF_MSG_RX_ERR | NETIF_MSG_TX_ERR)
@@ -50,6 +50,7 @@#define EHEA_MAX_ENTRIES_SQ 32767#define EHEA_MIN_ENTRIES_QP 127 +#define EHEA_SMALL_QUEUES #define EHEA_NUM_TX_QP 1#ifdef EHEA_SMALL_QUEUES
@@ -59,11 +60,11 @@#define EHEA_DEF_ENTRIES_RQ2 1023#define EHEA_DEF_ENTRIES_RQ3 1023#else -#define EHEA_MAX_CQE_COUNT 32000 -#define EHEA_DEF_ENTRIES_SQ 16000 -#define EHEA_DEF_ENTRIES_RQ1 32080 -#define EHEA_DEF_ENTRIES_RQ2 4020 -#define EHEA_DEF_ENTRIES_RQ3 4020 +#define EHEA_MAX_CQE_COUNT 4080 +#define EHEA_DEF_ENTRIES_SQ 4080 +#define EHEA_DEF_ENTRIES_RQ1 8160 +#define EHEA_DEF_ENTRIES_RQ2 2040 +#define EHEA_DEF_ENTRIES_RQ3 2040#endif #define EHEA_MAX_ENTRIES_EQ 20
drivers/net/ehea/ehea_main.c +6 -6
@@ -544,7 +544,7 @@ static irqreturn_t ehea_send_irq_handlerreturn IRQ_HANDLED ; } -static irqreturn_t ehea_recv_irq_handler (int irq,void *param, +static irqreturn_t ehea_recv_irq_handler (int irq,void *param,struct pt_regs *regs) {struct ehea_port_res *pr = param;
@@ -553,7 +553,7 @@ static irqreturn_t ehea_recv_irq_handlerreturn IRQ_HANDLED ; } -static irqreturn_t ehea_qp_aff_irq_handler (int irq,void *param, +static irqreturn_t ehea_qp_aff_irq_handler (int irq,void *param,struct pt_regs *regs) {struct ehea_port *port = param;
@@ -769,7 +769,7 @@ static void ehea_parse_eqe(struct ehea_aif (EHEA_BMASK_GET (NEQE_PORT_UP , eqe)) {if (!netif_carrier_ok (port->netdev)) { ret =ehea_sense_port_attr ( - adapter->port[portnum]); + port);if (ret) {ehea_error ("failed resensing port " "attributes" );
@@ -821,7 +821,7 @@ static void ehea_parse_eqe(struct ehea_anetif_stop_queue (port->netdev);break ;default : -ehea_error ("unknown event code %x" , ec); +ehea_error ("unknown event code %x, eqe=0x%lX" , ec, eqe);break ; } }
@@ -850,7 +850,7 @@ static void ehea_neq_tasklet(unsigned lo adapter->neq->fw_handle, event_mask); } -static irqreturn_t ehea_interrupt_neq (int irq,void *param, +static irqreturn_t ehea_interrupt_neq (int irq,void *param,struct pt_regs *regs) {struct ehea_adapter *adapter = param;
@@ -1845,7 +1845,7 @@ static int ehea_start_xmit(struct sk_bufif (netif_msg_tx_queued (port)) {ehea_info ("post swqe on QP %d" , pr->qp->init_attr.qp_nr); -ehea_dump (swqe,sizeof (*swqe),"swqe" ); +ehea_dump (swqe,512 ,"swqe" ); }ehea_post_swqe (pr->qp, swqe);
drivers/net/ehea/ehea_phyp.c +231 -328
727 lines not on this page · raw message
patch does not apply.
also, it would seem like varargs would be appropriate here.
Quoted 3 lines · Jeff Garzik
patch does not apply.
also, it would seem like varargs would be appropriate here.
Not really... these are hypervisor calls, their calling convention is not varargs, thus we would need some conversion layer if using them, with possible performance loss (it's also hard to do right as we are passing args by registers, not stack).
Ben.