Skip to contentSkip to conversation

avr32 architecture

PATCH David Woodhouse 3 participants 3 messages Sep 26, 2006 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 1 line · Linux Kernel Mailing List

[PATCH] avr32 architecture

pmac /pmac/git/linux-2.6 $ make ARCH=avr32 headers_check
CHK include/linux/version.h
make[1]: `scripts/unifdef' is up to date.
CHECK include/asm/user.h
CHECK include/asm/unistd.h
/pmac/git/linux-2.6/usr/include/asm/unistd.h requires linux/linkage.h, which does not exist in exported headers make[2]: *** [/pmac/git/linux-2.6/usr/include/asm/.check.unistd.h] Error 1

Signature · 1 line
dwmw2
#2 lore raw
Quoted 9 lines · David Woodhouse
Quoted 1 line · Linux Kernel Mailing List

[PATCH] avr32 architecture

pmac /pmac/git/linux-2.6 $ make ARCH=avr32 headers_check
CHK include/linux/version.h
make[1]: `scripts/unifdef' is up to date.
CHECK include/asm/user.h
CHECK include/asm/unistd.h
/pmac/git/linux-2.6/usr/include/asm/unistd.h requires linux/linkage.h, which does not exist in exported headers

Right. avr32-implement-kernel_execve.patch, which was flagged as "Will merge" by Andrew, fixes it by moving the #ifdef __KERNEL__ guard to cover everything but the __NR_foo definitions. So as long as that one's still scheduled for inclusion, I think sending a separate patch to fix this problem will do more harm than good.

But thanks for testing :)

Håvard

#3 lore raw
Quoted 11 lines · On Tue, 26 Sep 2006 23:17:29 +0200 "Haavard Skinnemoen"…
Quoted 9 lines · David Woodhouse
Quoted 1 line · Linux Kernel Mailing List

[PATCH] avr32 architecture

pmac /pmac/git/linux-2.6 $ make ARCH=avr32 headers_check
CHK include/linux/version.h
make[1]: `scripts/unifdef' is up to date.
CHECK include/asm/user.h
CHECK include/asm/unistd.h
/pmac/git/linux-2.6/usr/include/asm/unistd.h requires linux/linkage.h, which does not exist in exported headers

Quoted 3 lines

Right. avr32-implement-kernel_execve.patch, which was flagged as "Will merge" by Andrew, fixes it by moving the #ifdef __KERNEL__ guard to cover everything but the __NR_foo definitions.

Ho hum, such leakage happens sometimes.

Quoted 4 lines

So as long as that
one's still scheduled for inclusion, I think sending a separate patch to fix this problem will do more harm than good.

Yes, I'm planning on merging the execve cleanups for 2.6.19. It's probably a week away yet.