UML - Locking documentation
PATCH 3/5 UML - Locking documentation
Some locking documentation and a cleanup. uml_exitcode is copied into a local before sprintf sees it, in case sprintf does anything non-atomic with it.
The rest are comments about why certain globals don't need any kind of locking.
---
arch/um/drivers/null.c | 1 + arch/um/drivers/random.c | 4 ++++ arch/um/drivers/stderr_console.c | 2 ++ arch/um/drivers/stdio_console.c | 1 + arch/um/kernel/exitcode.c | 8 ++++++-- 5 files changed, 14 insertions(+), 2 deletions(-)
arch/um/kernel/exitcode.c +6 -2
@@ -16,9 +16,13 @@ int uml_exitcode = 0;static int read_proc_exitcode (char *page,char **start,off_t off,int count,int *eof,void *data) { -int len; +int len, val; - len =sprintf (page,"%d\n" , uml_exitcode); +/* Save uml_exitcode in a local so that we don't need to guarantee +* that sprintf accesses it atomically. +*/ + val = uml_exitcode; + len =sprintf (page,"%d\n" , val); len -= off;if (len <= off+count) *eof =1 ; *start = page + off;
arch/um/drivers/null.c +1 -0
@@ -8,6 +8,7 @@#include "chan_user.h" #include "os.h" +/* This address is used only as a unique identifer */ static int null_chan;static void *null_init (char *str,int device,const struct chan_opts *opts)
arch/um/drivers/random.c +4 -0
@@ -20,6 +20,10 @@#define RNG_MISCDEV_MINOR 183/* official */ +/* Changed at init time, in the non-modular case, and at module load +* time, in the module case. Presumably, the module subsystem +* protects against a module being loaded twice at the same time. +*/ static int random_fd =-1 ;static int rng_dev_open (struct inode *inode,struct file *filp)
arch/um/drivers/stderr_console.c +2 -0
@@ -9,6 +9,8 @@/* * Don't register by default -- as this registeres very early in the * boot process it becomes the default console. +* +* Initialized at init time. */ static int use_stderr_console =0 ;
arch/um/drivers/stdio_console.c +1 -0
@@ -107,6 +107,7 @@ static int con_open(struct tty_struct *treturn line_open (vts, tty); } +/* Set in an initcall, checked in an exitcall */ static int con_init_done =0 ;static const struct tty_operations console_ops = {
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
User-mode-linux-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel