UML - Stack consumption reduction
PATCH 5/5 UML - Stack consumption reduction
Fix some stack abuse in the sysrq t path.
Signed-off-by Jeff Dike <[email protected]>
---
arch/um/drivers/mconsole_kern.c | 15 ++++++++++----- arch/um/drivers/mconsole_user.c | 4 ++++ 2 files changed, 14 insertions(+), 5 deletions(-)
arch/um/drivers/mconsole_kern.c +10 -5
@@ -598,6 +598,11 @@ out:mconsole_reply (req, err_msg, err,0 ); } +struct mconsole_output { +struct list_head list; +struct mc_request *req; +}; +static DEFINE_SPINLOCK (console_lock);static LIST_HEAD (clients);static char console_buf[MCONSOLE_MAX_DATA ];
@@ -622,10 +627,10 @@ static void console_write(struct consolereturn ;list_for_each (ele, &clients){ -struct mconsole_entry *entry; +struct mconsole_output *entry; - entry = list_entry(ele, struct mconsole_entry, list); -mconsole_reply_len (&entry->request, console_buf, + entry = list_entry(ele, struct mconsole_output, list); +mconsole_reply_len (entry->req, console_buf, console_index,0 ,1 ); }
@@ -649,10 +654,10 @@ late_initcall(mc_add_console);static void with_console (struct mc_request *req,void (*proc)(void *),void *arg) { -struct mconsole_entry entry; +struct mconsole_output entry;unsigned long flags; - entry.request = *req; + entry.req = req;list_add (&entry.list, &clients);spin_lock_irqsave (&console_lock, flags);
arch/um/drivers/mconsole_user.c +4 -0
@@ -131,6 +131,10 @@ int mconsole_get_request(int fd, structint mconsole_reply_len (struct mc_request *req,const char *str,int total,int err,int more) { +/* XXX This is a stack consumption problem. It'd be nice to +* make it global and serialize access to it, but there are a +* ton of callers to this function. +*/ struct mconsole_reply reply;int len, n;
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
User-mode-linux-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel