Skip to contentSkip to conversation

pcie_portdrv_restore_config undefined without CONFIG_PM

DISCUSSION Olaf Hering 2 participants 3 messages Sep 27, 2006 – Sep 28, 2006 PCI

lore
Share & tools
lore
#0 lore raw

PCI-Express AER implemetation: pcie_portdrv error handler

This patch breaks if CONFIG_PM is not enabled,
pcie_portdrv_restore_config() will be undefined.

#1 lore raw
Quoted 4 lines · Olaf Hering

PCI-Express AER implemetation: pcie_portdrv error handler

This patch breaks if CONFIG_PM is not enabled,
pcie_portdrv_restore_config() will be undefined.

I move the definition of pcie_portdrv_restore_config out of CONFIG_PM.

Below patch is against 2.6.18-mm1. Could you try it?

---

drivers/pci/pcie/portdrv_pci.c +1 -1
diff -Nraup linux-2.6.18_mm1/drivers/pci/pcie/portdrv_pci.c linux-2.6.18_mm1_fix/drivers/pci/pcie/portdrv_pci.c
@@ -37,7 +37,6 @@ static int pcie_portdrv_save_config(stru
 	return pci_save_state(dev);
 }
 
-#ifdef CONFIG_PM
 static int pcie_portdrv_restore_config(struct pci_dev *dev)
 {
 	int retval;
@@ -50,6 +49,7 @@ static int pcie_portdrv_restore_config(s
 	return 0;
 }
 
+#ifdef CONFIG_PM
 static int pcie_portdrv_suspend(struct pci_dev *dev, pm_message_t state)
 {
 	int ret = pcie_port_device_suspend(dev, state);
#2 lore raw
Quoted 9 lines · Yanmin
Quoted 4 lines · Olaf Hering

PCI-Express AER implemetation: pcie_portdrv error handler

This patch breaks if CONFIG_PM is not enabled,
pcie_portdrv_restore_config() will be undefined.

I move the definition of pcie_portdrv_restore_config out of CONFIG_PM.

Below patch is against 2.6.18-mm1. Could you try it?

This fixes arch/powerpc/configs/cell_defconfig. Thanks.