Skip to contentSkip to conversation

qe_lib: Add common files

PATCH In review Kim Phillips 2 participants 2 messages Sep 30, 2006 – Oct 2, 2006 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 3/15 qe_lib: Add common files

qe_lib: Add common files

---
 arch/powerpc/Kconfig                   |   12 +
 arch/powerpc/sysdev/Makefile           |    1 
 arch/powerpc/sysdev/qe_lib/Kconfig     |   29 ++
 arch/powerpc/sysdev/qe_lib/Makefile    |    8 +
 arch/powerpc/sysdev/qe_lib/qe_common.c |  362 ++++++++++++++++++++++++
 include/asm-powerpc/qe.h               |  492 ++++++++++++++++++++++++++++++++
 6 files changed, 904 insertions(+), 0 deletions(-)
arch/powerpc/Kconfig +12 -0
index de1ef2f..0402209 100644
@@ -355,6 +355,16 @@ config APUS
 	  <http://linux-apus.sourceforge.net/>.
 endchoice
 
+config QUICC_ENGINE
+	bool
+	depends on PPC_MPC836x
+	default y
+	help
+	  The QE(QUICC Engine) is a new generation of coprocessor on
+	  Freescale embedded CPUs(like CPM  in older chips).  Selecting
+	  this option means that you wish to build a kernel for a machine
+	  with QE coprocessor on it.
+
 config PPC_PSERIES
 	depends on PPC_MULTIPLATFORM && PPC64
 	bool "IBM pSeries & new (POWER5-based) iSeries"
@@ -1059,6 +1069,8 @@ # XXX source "arch/ppc/8xx_io/Kconfig"
 
 # XXX source "arch/ppc/8260_io/Kconfig"
 
+source "arch/powerpc/sysdev/qe_lib/Kconfig"
+
 source "arch/powerpc/platforms/iseries/Kconfig"
 
 source "lib/Kconfig"
arch/powerpc/sysdev/Makefile +1 -0
index f15f4d7..91f052d 100644
@@ -12,6 +12,7 @@ obj-$(CONFIG_MMIO_NVRAM)	+= mmio_nvram.o
 obj-$(CONFIG_FSL_SOC)		+= fsl_soc.o
 obj-$(CONFIG_PPC_TODC)		+= todc.o
 obj-$(CONFIG_TSI108_BRIDGE)	+= tsi108_pci.o tsi108_dev.o
+obj-$(CONFIG_QUICC_ENGINE)	+= qe_lib/
 
 ifeq ($(CONFIG_PPC_MERGE),y)
 obj-$(CONFIG_PPC_I8259)		+= i8259.o
arch/powerpc/sysdev/qe_lib/Kconfig new file +29 -0
new file mode 100644
index 0000000..28487e4
@@ -0,0 +1,29 @@
+#
+# QE Communication options
+#
+
+menu "QE Options"
+	depends on QUICC_ENGINE
+
+config UCC_SLOW
+	bool "UCC Slow Protocols Support"
+	default n
+	select UCC
+	help
+	  This option provides qe_lib support to UCC slow
+	  protocols: UART, BISYNC, QMC
+
+config UCC_FAST
+	bool "UCC Fast Protocols Support"
+	default n
+	select UCC
+	help
+	  This option provides qe_lib support to UCC fast
+	  protocols: HDLC, Ethernet, ATM, transparent
+
+config UCC
+	bool
+	default y if UCC_FAST || UCC_SLOW
+
+endmenu
+
arch/powerpc/sysdev/qe_lib/Makefile new file +8 -0
new file mode 100644
index 0000000..9a54a81
@@ -0,0 +1,8 @@
+#
+# Makefile for the linux ppc-specific parts of QE
+#
+obj-$(CONFIG_QUICC_ENGINE)+= qe_common.o qe.o qe_ic.o qe_io.o
+
+obj-$(CONFIG_UCC)	+= ucc.o
+obj-$(CONFIG_UCC_SLOW)	+= ucc_slow.o
+obj-$(CONFIG_UCC_FAST)	+= ucc_fast.o ucc_slow.o
arch/powerpc/sysdev/qe_lib/qe_common.c new file +362 -0

362 lines not on this page · raw message

include/asm-powerpc/qe.h new file +492 -0

492 lines not on this page · raw message

Signature · 1 line
1.4.2.1
#1 lore raw

arch/powerpc/sysdev/qe_lib/Makefile line 4

Quoted 12 lines · Kim Phillips

qe_lib: Add common files

arch/powerpc/sysdev/qe_lib/Makefile new file +4 -0
new file mode 100644
index 0000000..9a54a81
@@ -0,0 +1,8 @@
+#
+# Makefile for the linux ppc-specific parts of QE
+#
+obj-$(CONFIG_QUICC_ENGINE)+= qe_common.o qe.o qe_ic.o qe_io.o

But qe.c, qe_ic.c and qe_io.c don't exist as of this patch, so the kernel won't build.

Also I notice that qe_common.c gets added by this patch and then modified by subsequent patches. Why don't we just add the final version instead?

It looks to me like most of this series needs to be committed as one commit so that git bisect still works. Please re-send the patches (except the rheap fix) as a series where the kernel will build and run after each patch in the series.

Also, when you are sending on a patch that someone else created, please make the first non-blank line of the message say "From: " followed by the author's name and email address, so we get the attribution right in the git repository.

Paul.