Skip to contentSkip to conversation

remove TxStartThresh and RxEarlyThresh

PATCH In review Jesse Huang 3 participants 4 messages Oct 2, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/5 remove TxStartThresh and RxEarlyThresh

From: Jesse Huang <[email protected]>

Change Logs:
For pattern issue need to remove TxStartThresh and RxEarlyThresh.

---

 drivers/net/sundance.c |    8 ++------
 1 files changed, 2 insertions(+), 6 deletions(-)

3751714e0fc36905c87a230172d9561c29321833

drivers/net/sundance.c +2 -6
index 6b8f4ba..a5dd1c3 100755
@@ -264,8 +264,6 @@ enum alta_offsets {
 	ASICCtrl = 0x30,
 	EEData = 0x34,
 	EECtrl = 0x36,
-	TxStartThresh = 0x3c,
-	RxEarlyThresh = 0x3e,
 	FlashAddr = 0x40,
 	FlashData = 0x44,
 	TxStatus = 0x46,
@@ -1111,6 +1109,7 @@ static irqreturn_t intr_handler(int irq,
 	int tx_cnt;
 	int tx_status;
 	int handled = 0;
+	int i;
 
 
 	do {
@@ -1153,17 +1152,14 @@ static irqreturn_t intr_handler(int irq,
 						np->stats.tx_fifo_errors++;
 					if (tx_status & 0x02)
 						np->stats.tx_window_errors++;
+
 					/*
 					** This reset has been verified on
 					** DFE-580TX boards ! [email protected].
 					*/
 					if (tx_status & 0x10) {	/* TxUnderrun */
-						unsigned short txthreshold;
-
-						txthreshold = ioread16 (ioaddr + TxStartThresh);
 						/* Restart Tx FIFO and transmitter */
 						sundance_reset(dev, (NetworkReset|FIFOReset|TxReset) << 16);
-						iowrite16 (txthreshold, ioaddr + TxStartThresh);
 						/* No need to reset the Tx pointer here */
 					}
 					/* Restart the Tx. */
Signature · 1 line
1.3.GIT
#1 lore raw
Quoted 1 line · On Mon, 02 Oct 2006 14:23:51 -0400 Jesse Huang <[email protected]> wrote:

For pattern issue need to remove TxStartThresh and RxEarlyThresh.

Please describe this issue more completely.

What are the implications of simply removing this feature? Presumably that code was there for a reason..

#2 lore raw
Quoted 6 lines
Quoted 1 line

For pattern issue need to remove TxStartThresh and RxEarlyThresh.

Please describe this issue more completely.

What are the implications of simply removing this feature? Presumably that code was there for a reason..

Actually I think this patch needs to be handled delicately -- because
based on earlier emails from Jesse (http://www.mail-archive.com/[email protected]/msg22254.html),
I am pretty sure that "pattern" is a typo for "patent". So I guess
the question is what exactly the patent covers and what the
implications of having the current kernel code are.

- R.

#3 lore raw

Sorry, I had typed wrong word.

It is because patent issue.

Thnaks.
----- Original Message -----
From: "Roland Dreier" <[email protected]>
To: "Andrew Morton" <[email protected]>
Cc: "Jesse Huang" <[email protected]>; <[email protected]>; <[email protected]>; <[email protected]>
Sent: Monday, October 02, 2006 3:00 PM
Subject: Re: [PATCH 1/5] remove TxStartThresh and RxEarlyThresh

Quoted 5 lines
Quoted 1 line

For pattern issue need to remove TxStartThresh and RxEarlyThresh.

Please describe this issue more completely.

What are the implications of simply removing this feature? Presumably

that

Quoted 1 line

code was there for a reason..

Actually I think this patch needs to be handled delicately -- because based on earlier emails from Jesse
(http://www.mail-archive.com/[email protected]/msg22254.html),
I am pretty sure that "pattern" is a typo for "patent". So I guess the question is what exactly the patent covers and what the implications of having the current kernel code are.

- R.