Skip to contentSkip to conversation

Fix bug in snd-usb-usx2y's usX2Y_pcms_lock_check()

PATCH In review Karsten Wiese 2 participants 2 messages Oct 3, 2006 – Oct 4, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix bug in snd-usb-usx2y's usX2Y_pcms_lock_check()

Fix bug in snd-usb-usx2y's usX2Y_pcms_lock_check()

substream can be NULL......
in mainline, bug was introduced by:
2006-06-22 [ALSA] Add O_APPEND flag support to PCM

usb/usx2y/usx2yhwdeppcm.c renamed from usb/usx2y/usx2yhwdeppcm.c~ +1 -1
@@ -632,7 +632,7 @@ static int usX2Y_pcms_lock_check(struct 
 		for (s = 0; s < 2; ++s) {
 			struct snd_pcm_substream *substream;
 			substream = pcm->streams[s].substream;
-			if (SUBSTREAM_BUSY(substream))
+			if (substream && SUBSTREAM_BUSY(substream))
 				err = -EBUSY;
 		}
 	}
#1 lore raw

At Tue, 3 Oct 2006 14:33:56 +0200,

Quoted 8 lines · Karsten Wiese

Fix bug in snd-usb-usx2y's usX2Y_pcms_lock_check()

substream can be NULL......
in mainline, bug was introduced by:
2006-06-22 [ALSA] Add O_APPEND flag support to PCM

Thanks, merged to ALSA tree.

Takashi

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV