Skip to contentSkip to conversation

Merge window closed: v2.6.19-rc1

DISCUSSION Voluspa 3 participants 4 messages Oct 5, 2006

lore
Share & tools
lore

Voluspa

author
#0 lore raw
  AR      arch/x86_64/lib/lib.a
  GEN     .version
  CHK     include/linux/compile.h
  UPD     include/linux/compile.h
  CC      init/version.o
  LD      init/built-in.o
  LD      vmlinux

arch/x86_64/kernel/built-in.o: In function `print_trace_warning_symbol':
traps.c:(.text.print_trace_warning_symbol+0xa): undefined reference to `print_symbol'
make: *** [vmlinux] Error 1

Mvh
Mats Johannesson

#1 lore raw
Quoted 11 lines · On Thu, 5 Oct 2006 18:49:16 +0200 Voluspa wrote:
  AR      arch/x86_64/lib/lib.a
  GEN     .version
  CHK     include/linux/compile.h
  UPD     include/linux/compile.h
  CC      init/version.o
  LD      init/built-in.o
  LD      vmlinux

arch/x86_64/kernel/built-in.o: In function `print_trace_warning_symbol':
traps.c:(.text.print_trace_warning_symbol+0xa): undefined reference to `print_symbol'
make: *** [vmlinux] Error 1

You don't have CONFIG_KALLSYMS enabled?

Does this patch fix the build for you?

---
From: Randy Dunlap <[email protected]>

Include linux/kallsyms.h unconditionally for print_symbol().

---
 arch/x86_64/kernel/traps.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
arch/x86_64/kernel/traps.c +1 -1
@@ -23,6 +23,7 @@
 #include <linux/delay.h>
 #include <linux/spinlock.h>
 #include <linux/interrupt.h>
+#include <linux/kallsyms.h>
 #include <linux/module.h>
 #include <linux/moduleparam.h>
 #include <linux/nmi.h>
@@ -115,7 +116,6 @@ static int call_trace = 1;
 #endif
 
 #ifdef CONFIG_KALLSYMS
-# include <linux/kallsyms.h>
 void printk_address(unsigned long address)
 {
 	unsigned long offset = 0, symsize;
#2 lore raw
Quoted 5 lines

You don't have CONFIG_KALLSYMS enabled?

Does this patch fix the build for you?

Added thanks

-Andi

author
#3 lore raw
In reply to Randy Dunlap
Quoted 14 lines · On Thu, 5 Oct 2006 09:59:44 -0700 Randy Dunlap wrote:
Quoted 11 lines · On Thu, 5 Oct 2006 18:49:16 +0200 Voluspa wrote:
  AR      arch/x86_64/lib/lib.a
  GEN     .version
  CHK     include/linux/compile.h
  UPD     include/linux/compile.h
  CC      init/version.o
  LD      init/built-in.o
  LD      vmlinux

arch/x86_64/kernel/built-in.o: In function `print_trace_warning_symbol':
traps.c:(.text.print_trace_warning_symbol+0xa): undefined reference to `print_symbol' make: *** [vmlinux] Error 1

Quoted 1 line

You don't have CONFIG_KALLSYMS enabled?

Never. I like to keep the kernel as lean as possible until some bug-reporting requires otherwise.

Quoted 2 lines

Does this patch fix the build for you?

Perfect. Thanx. Built, but haven't booted yet.

Mvh
Mats Johannesson