Skip to contentSkip to conversation

Symbol conflict in QLA drivers

DISCUSSION David Howells 3 participants 4 messages Oct 5, 2006 SCSI

lore
Share & tools
lore
#0 lore raw

Two different QLA drivers (qla2xxx and qla4xxx) both define a variable called:

extended_error_logging

This results in a namespace conflict when both drivers are compiled in (make allyesconfig for example).

David

#1 lore raw
Quoted 9 lines · David Howells

Two different QLA drivers (qla2xxx and qla4xxx) both define a variable called:

extended_error_logging

This results in a namespace conflict when both drivers are compiled in (make allyesconfig for example).

We will push a patch to fix it in qla4xxx driver.

Thanx
Ravi

#2 lore raw
Quoted 1 line · ravianand

We will push a patch to fix it in qla4xxx driver.

Actually, if the symbol can't be made static, please fix both (say with a qla2/qla4 prefix or something) just so we don't get clashes with other areas of the kernel.

James

#3 lore raw
Quoted 8 lines · James Bottomley
Quoted 1 line · ravianand

We will push a patch to fix it in qla4xxx driver.

Actually, if the symbol can't be made static, please fix both (say with a qla2/qla4 prefix or something) just so we don't get clashes with other areas of the kernel.

Make sense. We will fix both.

Thanx
Ravi