Skip to contentSkip to conversation

sunifdef instead of unifdef

DISCUSSION Dennis Heuer 6 participants 7 messages Oct 5, 2006 – Oct 9, 2006

lore
Share & tools
lore
#0 lore raw

Hello

unifdef is not only very old and unmaintained, the binary does not work and the source does not compile on a pure x86_64 system. There is another tool that worked for me--though it 'closed with remarks'--and that was updated recently (several times this year). It is called sunifdef, is under an equal (new) BSD license, and is proposed to be the successor of unifdef. See the project page:

http://www.sunifdef.strudl.org/

Regards,
Dennis

#1 lore raw
Quoted 8 lines · Dennis Heuer

unifdef is not only very old and unmaintained, the binary does not work and the source does not compile on a pure x86_64 system. There is another tool that worked for me--though it 'closed with remarks'--and that was updated recently (several times this year). It is called sunifdef, is under an equal (new) BSD license, and is proposed to be the successor of unifdef. See the project page:

http://www.sunifdef.strudl.org/

What about posting compiler errors instead of suggesting something that is 10 times bigger?

#2 lore raw
In reply to Dennis Heuer
Quoted 2 lines · Dennis Heuer

unifdef is not only very old and unmaintained, the binary does not work and the source does not compile on a pure x86_64 system.

It works for me. Describe your problem more coherently.

I wouldn't describe it as 'very old' -- the last commit seems to have been last March, which isn't _so_ recent but perhaps it just hasn't _needed_ an update?

Neither would I describe it as unmaintained. Tony was quite quickly responsive when I asked him if it would be OK to include unifdef in the kernel source tree.

Quoted 6 lines

There is another tool that worked for me--though it 'closed with remarks'--and that was updated recently (several times this year). It is called sunifdef, is under an equal (new) BSD license, and is proposed to be the successor of unifdef. See the project page:

http://www.sunifdef.strudl.org/

I don't see a huge point in changing, unless it lets us get rid of stuff like

	#if defined(__KERNEL__ && ....

when used with -U__KERNEL__.

Signature · 1 line
dwmw2
#3 lore raw
Quoted 8 lines · David Woodhouse

I wouldn't describe it as 'very old' -- the last commit seems to have been last March, which isn't _so_ recent but perhaps it just hasn't _needed_ an update?

Neither would I describe it as unmaintained. Tony was quite quickly responsive when I asked him if it would be OK to include unifdef in the kernel source tree.

I haven't received any contributions to unifdef in the last 18 months which is why it hasn't changed. Yes, it has some significant gaps in its functionality, but it's reasonably correct within its current scope. (I tend to think that if you need more advanced functionality then you are already in serious trouble: for example, my unifdef was written so that I could understand xterm's frightening pty handling....) I don't have a lot of time to make extensive changes to unifdef, and given that sunifdef exists there is not much point. Thanks for telling me about it: I didn't know it existed, and it's nice to see other people basing such great stuff on my work.

Quoted 3 lines

I don't see a huge point in changing, unless it lets us get rid of stuff like

	#if defined(__KERNEL__ && ....

I don't think your syntax errors are my problem :-)

Tony.

Signature · 3 lines
f.a.n.finch  <[email protected]>  http://dotat.at/
FORTIES CROMARTY FORTH: SOUTHERLY 6 TO GALE 8, DECREASING 5 OR 6 LATER. RAIN
OR SHOWERS. MODERATE OR GOOD.
#4 lore raw
Quoted 3 lines · Tony Finch
Quoted 1 line
      #if defined(__KERNEL__ && ....

I don't think your syntax errors are my problem :-)

Heh, good point :)

Signature · 1 line
dwmw2
#5 lore raw
In reply to Tony Finch
Quoted 2 lines

I haven't received any contributions to unifdef in the last 18 months which is why it hasn't changed.

Reminds me - I did a small change to avoid dependency on strlcpy.

You can see it here:
http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=14a036d2dc304797f3624c06bd6d2a1e9b59e45a

I strongly preferred 8 simple codelines as replacement for carrying strlcpy in a seperate file. Feel free to include this in your unifdef as you whish.

Sam

#6 lore raw
In reply to Tony Finch
Quoted 2 lines · Tony Finch

already in serious trouble: for example, my unifdef was written so that I could understand xterm's frightening pty handling....)

Well, that code *does* warn you:

* If you think you know what all of this code is doing, you are
* probably very mistaken. There be serious and nasty dragons here.

:)