Skip to contentSkip to conversation

gitweb: Remove redundant "commit" link from shortlog

PATCH In review Luben Tuikov 3 participants 5 messages Jun 15, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gitweb: Remove redundant "commit" link from shortlog

Remove the redundant "commit" link from shortlog. It can be had by simply clicking on the entry title of the row.

---
 gitweb/gitweb.perl |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
gitweb/gitweb.perl +0 -1
index 79c8052..f3f22c2 100755
@@ -2013,7 +2013,6 @@ sub git_shortlog_body {
 		                          href(action=>"commit", hash=>$commit), $ref);
 		print "</td>\n" .
 		      "<td class=\"link\">" .
-		      $cgi->a({-href => href(action=>"commit", hash=>$commit)}, "commit") . " | " .
 		      $cgi->a({-href => href(action=>"commitdiff", hash=>$commit)}, "commitdiff") . " | " .
 		      $cgi->a({-href => href(action=>"tree", hash=>$commit, hash_base=>$commit)}, "tree");
 		print "</td>\n" .
Signature · 1 line
1.4.2.1.g05f0f
#1 lore raw

Dear diary, on Fri, Sep 29, 2006 at 01:48:40AM CEST, I got a letter where Luben Tuikov <[email protected]> said that...

Quoted 5 lines

Remove the redundant "commit" link from shortlog. It can be had by simply clicking on the entry title of the row.

And what if the commit message is empty?

Witness at http://repo.or.cz/?p=test;a=summary

Signature · 5 lines
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj
$/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1
lK[d2%Sa2/d0$^Ixp"|dc`;s/\W//g;$_=pack('H*',/((..)*)$/)
#2 lore raw

PATCH 1/1 gitweb: Handle commits with empty commit messages more reasonably

Currently those look very weird, you can't get easily at the commit view etc. This patch makes their title '(no commit message)'.

---

 gitweb/gitweb.perl |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
gitweb/gitweb.perl +3 -0
index ea159e9..56e5231 100755
@@ -1115,6 +1115,9 @@ sub parse_commit {
 			last;
 		}
 	}
+	if ($co{'title'} eq "") {
+		$co{'title'} = $co{'title_short'} = '(no commit message)';
+	}
 	# remove added spaces
 	foreach my $line (@commit_lines) {
 		$line =~ s/^    //;
#3 lore raw
In reply to Petr Baudis
Quoted 11 lines · --- Petr Baudis

Dear diary, on Fri, Sep 29, 2006 at 01:48:40AM CEST, I got a letter where Luben Tuikov <[email protected]> said that...

Quoted 5 lines

Remove the redundant "commit" link from shortlog. It can be had by simply clicking on the entry title of the row.

And what if the commit message is empty?

Witness at http://repo.or.cz/?p=test;a=summary

Clearly a pathological case. Who or why would anyone do this? I don't think we should worry about such pathological cases.

Commits without commit messages do not question GIT. They question the committer... (that's the morning chuckle)

Luben

Quoted 12 lines
Signature · 10 lines
-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj
$/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1
lK[d2%Sa2/d0$^Ixp"|dc`;s/\W//g;$_=pack('H*',/((..)*)$/)
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#4 lore raw
In reply to Petr Baudis
Quoted 11 lines · Petr Baudis

Dear diary, on Fri, Sep 29, 2006 at 01:48:40AM CEST, I got a letter where Luben Tuikov <[email protected]> said that...

Quoted 5 lines

Remove the redundant "commit" link from shortlog. It can be had by simply clicking on the entry title of the row.

And what if the commit message is empty?

Witness at http://repo.or.cz/?p=test;a=summary

By the way, commitdiff view in this case also looks strange. I think that simplyfying the git_difftree_body went too far, Luben.

Signature · 3 lines
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git