Add Kconfig dependency !VT for VIOCONS
Subsystems (2)
PATCH 1/1 Add Kconfig dependency !VT for VIOCONS
From: Judith Lebzelter <[email protected]>
Add Kconfig dependency !VT for VIOCONS
I would like to avoid this compile error in 'allmodconfig':drivers/char/viocons.c:52:2: error: #error You must turn off CONFIG_VT to use CONFIG_VIOCONS
---
arch/powerpc/platforms/iseries/Kconfig +1 -0
@@ -4,6 +4,7 @@ config VIOCONS tristate "iSeries Virtual Console Support (Obsolete)" + depends on !VT help This is the old virtual console driver for legacy iSeries. You should use the iSeries Hypervisor Virtual Console
Actually, this gets rid of the CONFIG_VIOCONS from my .config, but then I get another warning when I build:
Warning! Found recursive dependency: VT VIOCONS VT
Can anyone suggest something?
Thanks,
Judith
Quoted 26 lines · Judith Lebzelter
From: Judith Lebzelter <[email protected]>
Add
Kconfigdependency !VT for VIOCONSI would like to avoid this compile error in 'allmodconfig':
drivers/char/viocons.c:52:2: error: #error You must turn offCONFIG_VTto useCONFIG_VIOCONSSigned-off-by Judith Lebzelter <[email protected]>---
Index: linux/arch/powerpc/platforms/iseries/Kconfig
===================================================================arch/powerpc/platforms/iseries/Kconfig +1
-0@@ -4,6 +4,7 @@ config VIOCONS tristate "iSeries Virtual Console Support (Obsolete)" + depends on !VT help This is the old virtual console driver for legacy iSeries. You should use the iSeries Hypervisor Virtual Console_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Quoted 6 lines · On Fri, 6 Oct 2006 13:00:07 -0700 Judith Lebzelter wrote:
Actually, this gets rid of the
CONFIG_VIOCONSfrom my .config, but then I get another warning when I build:Warning! Found recursive dependency: VT VIOCONS VT
Can anyone suggest something?
I think that your patch is mostly good/correct, but one more line is needed on the VT side: a deletion.
This works for me:
From: Randy Dunlap <[email protected]>
Make allmodconfig .config build successfully by making VIOCONS available only if VT=n. VT need not check VIOCONS.
--- arch/powerpc/platforms/iseries/Kconfig | 2 +- drivers/char/Kconfig | 1 - 2 files changed, 1 insertion(+), 2 deletions(-)
arch/powerpc/platforms/iseries/Kconfig +1 -1
@@ -3,7 +3,7 @@ menu "iSeries device drivers" depends on PPC_ISERIES config VIOCONS - tristate "iSeries Virtual Console Support (Obsolete)" + tristate "iSeries Virtual Console Support (Obsolete)" if !VT help This is the old virtual console driver for legacy iSeries. You should use the iSeries Hypervisor Virtual Console
drivers/char/Kconfig +0 -1
@@ -7,7 +7,6 @@ menu "Character devices" config VT bool "Virtual terminal" if EMBEDDED select INPUT - default y if !VIOCONS ---help--- If you say Y here, you will get support for terminal devices with display and keyboard devices. These are called "virtual" because you
Quoted 20 lines
Thanks,
JudithQuoted 16 lines · Judith Lebzelter
From: Judith Lebzelter <[email protected]>
Add
Kconfigdependency !VT for VIOCONSI would like to avoid this compile error in 'allmodconfig':
drivers/char/viocons.c:52:2: error: #error You must turn offCONFIG_VTto useCONFIG_VIOCONSSigned-off-by Judith Lebzelter <[email protected]>---
Index: linux/arch/powerpc/platforms/iseries/Kconfig
===================================================================arch/powerpc/platforms/iseries/Kconfig +0
-0@@ -4,6 +4,7 @@
Quoted 6 lines
arch/powerpc/platforms/iseries/Kconfig line 10
Quoted 6 lines
arch/powerpc/platforms/iseries/Kconfig +1
-0config VIOCONS tristate "iSeries Virtual Console Support (Obsolete)" + depends on !VT help This is the old virtual console driver for legacy iSeries. You should use the iSeries Hypervisor Virtual Console
---
~Randy
Quoted 28 lines · Randy Dunlap
Quoted 6 lines · On Fri, 6 Oct 2006 13:00:07 -0700 Judith Lebzelter wrote:
Actually, this gets rid of the
CONFIG_VIOCONSfrom my .config, but then I get another warning when I build:Warning! Found recursive dependency: VT VIOCONS VT
Can anyone suggest something?
I think that your patch is mostly good/correct, but one more line is needed on the VT side: a deletion.
This works for me:
From: Randy Dunlap <[email protected]>
Make allmodconfig .config build successfully by making VIOCONS available only if VT=n. VT need not check VIOCONS.
Signed-off-by Randy Dunlap <[email protected]>--- arch/powerpc/platforms/iseries/Kconfig | 2 +- drivers/char/Kconfig | 1 - 2 files changed, 1 insertion(+), 2 deletions(-)
arch/powerpc/platforms/iseries/Kconfig menu "iSeries device drivers"
Quoted 9 lines
arch/powerpc/platforms/iseries/Kconfig +1
-1@@ -3,7 +3,7 @@ menu "iSeries device drivers" depends on PPC_ISERIES config VIOCONS - tristate "iSeries Virtual Console Support (Obsolete)" + tristate "iSeries Virtual Console Support (Obsolete)" if !VT help config VT bool "Virtual terminal" if EMBEDDED
With this dependency on EMBEDDED, you could as well simply remove VIOCONS...
arch/powerpc/platforms/iseries/Kconfig
Quoted 2 lines
arch/powerpc/platforms/iseries/Kconfig +0
-1select INPUT - default y if !VIOCONS
Removing the "default y" is wrong.
Quoted 5 lines
arch/powerpc/platforms/iseries/Kconfig +0
-0---help--- If you say Y here, you will get support for terminal devices with display and keyboard devices. These are called "virtual" because you~Randy
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedQuoted 42 lines · On Tue, 10 Oct 2006 06:55:34 +0200 Adrian Bunk wrote:
Quoted 28 lines · Randy Dunlap
Quoted 6 lines · On Fri, 6 Oct 2006 13:00:07 -0700 Judith Lebzelter wrote:
Actually, this gets rid of the
CONFIG_VIOCONSfrom my .config, but then I get another warning when I build:Warning! Found recursive dependency: VT VIOCONS VT
Can anyone suggest something?
I think that your patch is mostly good/correct, but one more line is needed on the VT side: a deletion.
This works for me:
From: Randy Dunlap <[email protected]>
Make allmodconfig .config build successfully by making VIOCONS available only if VT=n. VT need not check VIOCONS.
Signed-off-by Randy Dunlap <[email protected]>--- arch/powerpc/platforms/iseries/Kconfig | 2 +- drivers/char/Kconfig | 1 - 2 files changed, 1 insertion(+), 2 deletions(-)arch/powerpc/platforms/iseries/Kconfig menu "iSeries device drivers"
Quoted 9 lines
arch/powerpc/platforms/iseries/Kconfig +1
-1@@ -3,7 +3,7 @@ menu "iSeries device drivers" depends on PPC_ISERIES config VIOCONS - tristate "iSeries Virtual Console Support (Obsolete)" + tristate "iSeries Virtual Console Support (Obsolete)" if !VT help config VT bool "Virtual terminal" if EMBEDDEDWith this dependency on EMBEDDED, you could as well simply remove VIOCONS...
Quoted 4 lines
arch/powerpc/platforms/iseries/Kconfig
Quoted 2 lines
arch/powerpc/platforms/iseries/Kconfig +0
-1select INPUT - default y if !VIOCONSRemoving the "default y" is wrong.
Oops, yes, agreed.
I don't see a way (using: make ARCH=powerpc iseries_defconfig, which wants to enable VIOCONS) to prevent VT from being enabled so that VIOCONS can be enabled.
However, since VIOCONS is marked (Obsolete) and since the powerpc people don't comment on this patch & problem, maybe Judith is the only person who cares.
Quoted 4 lines
arch/powerpc/platforms/iseries/Kconfig
Quoted 4 lines
arch/powerpc/platforms/iseries/Kconfig +0
-0---help--- If you say Y here, you will get support for terminal devices with display and keyboard devices. These are called "virtual" because you
---
~Randy
Quoted 49 lines · Randy Dunlap
Quoted 42 lines · On Tue, 10 Oct 2006 06:55:34 +0200 Adrian Bunk wrote:
Quoted 28 lines · Randy Dunlap
Quoted 6 lines · On Fri, 6 Oct 2006 13:00:07 -0700 Judith Lebzelter wrote:
Actually, this gets rid of the
CONFIG_VIOCONSfrom my .config, but then I get another warning when I build:Warning! Found recursive dependency: VT VIOCONS VT
Can anyone suggest something?
I think that your patch is mostly good/correct, but one more line is needed on the VT side: a deletion.
This works for me:
From: Randy Dunlap <[email protected]>
Make allmodconfig .config build successfully by making VIOCONS available only if VT=n. VT need not check VIOCONS.
Signed-off-by Randy Dunlap <[email protected]>--- arch/powerpc/platforms/iseries/Kconfig | 2 +- drivers/char/Kconfig | 1 - 2 files changed, 1 insertion(+), 2 deletions(-)arch/powerpc/platforms/iseries/Kconfig menu "iSeries device drivers"
Quoted 9 lines
arch/powerpc/platforms/iseries/Kconfig +1
-1@@ -3,7 +3,7 @@ menu "iSeries device drivers" depends on PPC_ISERIES config VIOCONS - tristate "iSeries Virtual Console Support (Obsolete)" + tristate "iSeries Virtual Console Support (Obsolete)" if !VT help config VT bool "Virtual terminal" if EMBEDDEDWith this dependency on EMBEDDED, you could as well simply remove VIOCONS...
Quoted 4 lines
arch/powerpc/platforms/iseries/Kconfig
Quoted 2 lines
arch/powerpc/platforms/iseries/Kconfig +0
-1select INPUT - default y if !VIOCONSRemoving the "default y" is wrong.
Quoted 5 lines
Oops, yes, agreed.
I don't see a way (using: make ARCH=powerpc
iseries_defconfig, which wants to enable VIOCONS) to prevent VT from being enabled so that VIOCONS can be enabled.
With iseries_defconfig, CONFIG_VT is not enabled.
Quoted 3 lines
However, since VIOCONS is marked (Obsolete) and since the powerpc people don't comment on this patch & problem, maybe Judith is the only person who cares.
allmodconfig turns on CONFIG_EMBEDDED.
Quoted 1 line
~Randy
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedQuoted 56 lines · On Wed, 11 Oct 2006 05:56:29 +0200 Adrian Bunk wrote:
Quoted 49 lines · Randy Dunlap
Quoted 42 lines · On Tue, 10 Oct 2006 06:55:34 +0200 Adrian Bunk wrote:
Quoted 28 lines · Randy Dunlap
Quoted 6 lines · On Fri, 6 Oct 2006 13:00:07 -0700 Judith Lebzelter wrote:
Actually, this gets rid of the
CONFIG_VIOCONSfrom my .config, but then I get another warning when I build:Warning! Found recursive dependency: VT VIOCONS VT
Can anyone suggest something?
I think that your patch is mostly good/correct, but one more line is needed on the VT side: a deletion.
This works for me:
From: Randy Dunlap <[email protected]>
Make allmodconfig .config build successfully by making VIOCONS available only if VT=n. VT need not check VIOCONS.
Signed-off-by Randy Dunlap <[email protected]>--- arch/powerpc/platforms/iseries/Kconfig | 2 +- drivers/char/Kconfig | 1 - 2 files changed, 1 insertion(+), 2 deletions(-)arch/powerpc/platforms/iseries/Kconfig menu "iSeries device drivers"
Quoted 9 lines
arch/powerpc/platforms/iseries/Kconfig +1
-1@@ -3,7 +3,7 @@ menu "iSeries device drivers" depends on PPC_ISERIES config VIOCONS - tristate "iSeries Virtual Console Support (Obsolete)" + tristate "iSeries Virtual Console Support (Obsolete)" if !VT help config VT bool "Virtual terminal" if EMBEDDEDWith this dependency on EMBEDDED, you could as well simply remove VIOCONS...
Quoted 4 lines
arch/powerpc/platforms/iseries/Kconfig
Quoted 2 lines
arch/powerpc/platforms/iseries/Kconfig +0
-1select INPUT - default y if !VIOCONSRemoving the "default y" is wrong.
Quoted 5 lines
Oops, yes, agreed.
I don't see a way (using: make ARCH=powerpc
iseries_defconfig, which wants to enable VIOCONS) to prevent VT from being enabled so that VIOCONS can be enabled.
Quoted 7 lines
With
iseries_defconfig,CONFIG_VTis not enabled.Quoted 3 lines
However, since VIOCONS is marked (Obsolete) and since the powerpc people don't comment on this patch & problem, maybe Judith is the only person who cares.
allmodconfig turns on
CONFIG_EMBEDDED.
So am I doing this incorrectly?
$ make ARCH=powerpc iseries_defconfig
$editor .config
CONFIG_VT=y
...
#
# iSeries device drivers
#CONFIG_VIODASD=yCONFIG_VIOCD=mCONFIG_VIOTAPE=mCONFIG_VIOPATH=y
---
~Randy
Quoted 72 lines · Randy Dunlap
Quoted 56 lines · On Wed, 11 Oct 2006 05:56:29 +0200 Adrian Bunk wrote:
Quoted 49 lines · Randy Dunlap
Quoted 42 lines · On Tue, 10 Oct 2006 06:55:34 +0200 Adrian Bunk wrote:
Quoted 28 lines · Randy Dunlap
Quoted 6 lines · On Fri, 6 Oct 2006 13:00:07 -0700 Judith Lebzelter wrote:
Actually, this gets rid of the
CONFIG_VIOCONSfrom my .config, but then I get another warning when I build:Warning! Found recursive dependency: VT VIOCONS VT
Can anyone suggest something?
I think that your patch is mostly good/correct, but one more line is needed on the VT side: a deletion.
This works for me:
From: Randy Dunlap <[email protected]>
Make allmodconfig .config build successfully by making VIOCONS available only if VT=n. VT need not check VIOCONS.
Signed-off-by Randy Dunlap <[email protected]>--- arch/powerpc/platforms/iseries/Kconfig | 2 +- drivers/char/Kconfig | 1 - 2 files changed, 1 insertion(+), 2 deletions(-)arch/powerpc/platforms/iseries/Kconfig menu "iSeries device drivers"
Quoted 9 lines
arch/powerpc/platforms/iseries/Kconfig +1
-1@@ -3,7 +3,7 @@ menu "iSeries device drivers" depends on PPC_ISERIES config VIOCONS - tristate "iSeries Virtual Console Support (Obsolete)" + tristate "iSeries Virtual Console Support (Obsolete)" if !VT help config VT bool "Virtual terminal" if EMBEDDEDWith this dependency on EMBEDDED, you could as well simply remove VIOCONS...
Quoted 4 lines
arch/powerpc/platforms/iseries/Kconfig
Quoted 2 lines
arch/powerpc/platforms/iseries/Kconfig +0
-1select INPUT - default y if !VIOCONSRemoving the "default y" is wrong.
Quoted 5 lines
Oops, yes, agreed.
I don't see a way (using: make ARCH=powerpc
iseries_defconfig, which wants to enable VIOCONS) to prevent VT from being enabled so that VIOCONS can be enabled.Quoted 7 lines
With
iseries_defconfig,CONFIG_VTis not enabled.Quoted 3 lines
However, since VIOCONS is marked (Obsolete) and since the powerpc people don't comment on this patch & problem, maybe Judith is the only person who cares.
allmodconfig turns on
CONFIG_EMBEDDED.So am I doing this incorrectly?
$ make ARCH=powerpc iseries_defconfig$editor .config
Quoted 9 lines
CONFIG_VT=y
...
#
# iSeries device drivers
#CONFIG_VIODASD=yCONFIG_VIOCD=mCONFIG_VIOTAPE=mCONFIG_VIOPATH=y
CONFIG_VIOCONS is not enabled.
Quoted 1 line
~Randy
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedQuoted 83 lines · On Wed, 11 Oct 2006 06:30:06 +0200 Adrian Bunk wrote:
Quoted 72 lines · Randy Dunlap
Quoted 56 lines · On Wed, 11 Oct 2006 05:56:29 +0200 Adrian Bunk wrote:
Quoted 49 lines · Randy Dunlap
Quoted 42 lines · On Tue, 10 Oct 2006 06:55:34 +0200 Adrian Bunk wrote:
Quoted 28 lines · Randy Dunlap
Quoted 6 lines · On Fri, 6 Oct 2006 13:00:07 -0700 Judith Lebzelter wrote:
Actually, this gets rid of the
CONFIG_VIOCONSfrom my .config, but then I get another warning when I build:Warning! Found recursive dependency: VT VIOCONS VT
Can anyone suggest something?
I think that your patch is mostly good/correct, but one more line is needed on the VT side: a deletion.
This works for me:
From: Randy Dunlap <[email protected]>
Make allmodconfig .config build successfully by making VIOCONS available only if VT=n. VT need not check VIOCONS.
Signed-off-by Randy Dunlap <[email protected]>--- arch/powerpc/platforms/iseries/Kconfig | 2 +- drivers/char/Kconfig | 1 - 2 files changed, 1 insertion(+), 2 deletions(-)arch/powerpc/platforms/iseries/Kconfig menu "iSeries device drivers"
Quoted 9 lines
arch/powerpc/platforms/iseries/Kconfig +1
-1@@ -3,7 +3,7 @@ menu "iSeries device drivers" depends on PPC_ISERIES config VIOCONS - tristate "iSeries Virtual Console Support (Obsolete)" + tristate "iSeries Virtual Console Support (Obsolete)" if !VT help config VT bool "Virtual terminal" if EMBEDDEDWith this dependency on EMBEDDED, you could as well simply remove VIOCONS...
Quoted 4 lines
arch/powerpc/platforms/iseries/Kconfig
Quoted 2 lines
arch/powerpc/platforms/iseries/Kconfig +0
-1select INPUT - default y if !VIOCONSRemoving the "default y" is wrong.
Quoted 5 lines
Oops, yes, agreed.
I don't see a way (using: make ARCH=powerpc
iseries_defconfig, which wants to enable VIOCONS) to prevent VT from being enabled so that VIOCONS can be enabled.Quoted 7 lines
With
iseries_defconfig,CONFIG_VTis not enabled.Quoted 3 lines
However, since VIOCONS is marked (Obsolete) and since the powerpc people don't comment on this patch & problem, maybe Judith is the only person who cares.
allmodconfig turns on
CONFIG_EMBEDDED.So am I doing this incorrectly?
$ make ARCH=powerpc iseries_defconfig$editor .config
Quoted 9 lines
CONFIG_VT=y
...
#
# iSeries device drivers
#CONFIG_VIODASD=yCONFIG_VIOCD=mCONFIG_VIOTAPE=mCONFIG_VIOPATH=y
Quoted 1 line
CONFIG_VIOCONSis not enabled.
Yep. That was with my patch.
But I see what you mean. Thanks.
---
~Randy