Skip to contentSkip to conversation

kernel-doc: make parameter description indentation uniform

PATCH New Randy Dunlap 1 participant 1 message Oct 9, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kernel-doc: make parameter description indentation uniform

From: Randy Dunlap <[email protected]>

- In parameter descriptions, strip all whitespace between the parameter name (e.g., @len) and its description so that the description is indented uniformly in text and man page modes. Previously, spaces or tabs (which are used for cleaner source code viewing) affected the produced output in a negative way.

Before (man mode):
to Destination address, in user space.
from Source address, in kernel space.
n Number of bytes to copy.

After (man mode):

       to          Destination address, in user space.
       from        Source address, in kernel space.
       n           Number of bytes to copy.

- Fix/clarify a few function description comments.

---
 scripts/kernel-doc |   12 +++++++-----
 1 files changed, 7 insertions(+), 5 deletions(-)
scripts/kernel-doc +7 -5
@@ -1262,7 +1262,9 @@ sub output_intro_text(%) {
 }
 
 ##
-# generic output function for typedefs
+# generic output function for all types (function, struct/union, typedef, enum);
+# calls the generated, variable output_ function name based on
+# functype and output_mode
 sub output_declaration {
     no strict 'refs';
     my $name = shift;
@@ -1278,8 +1280,7 @@ sub output_declaration {
 }
 
 ##
-# generic output function - calls the right one based
-# on current output mode.
+# generic output function - calls the right one based on current output mode.
 sub output_intro {
     no strict 'refs';
     my $func = "output_intro_".$output_mode;
@@ -1782,8 +1783,9 @@ sub process_file($) {
 		$in_doc_sect = 1;
 		$contents = $newcontents;
 		if ($contents ne "") {
-		    if (substr($contents, 0, 1) eq " ") {
-			$contents = substr($contents, 1);
+		    while ((substr($contents, 0, 1) eq " ") ||
+			substr($contents, 0, 1) eq "\t") {
+			    $contents = substr($contents, 1);
 		    }
 		    $contents .= "\n";
 		}

---