Skip to contentSkip to conversation

driver core: warn unused return value for internal functions

PATCH New Akinobu Mita 1 participant 1 message Oct 9, 2006 Driver core

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 driver core: warn unused return value for internal functions

This patch adds __must_check attribute to driver core internal functions (drivers/base/base.h)

Cc Greg Kroah-Hartman <[email protected]>
 drivers/base/base.h |   31 ++++++++++++++++---------------
 1 file changed, 16 insertions(+), 15 deletions(-)
drivers/base/base.h +16 -15
Index: work-fault-inject/drivers/base/base.h
===================================================================
@@ -1,35 +1,36 @@
+#include <linux/compiler.h>
 
 /* initialisation functions */
 
-extern int devices_init(void);
-extern int buses_init(void);
-extern int classes_init(void);
-extern int firmware_init(void);
+extern int __must_check devices_init(void);
+extern int __must_check buses_init(void);
+extern int __must_check classes_init(void);
+extern int __must_check firmware_init(void);
 #ifdef CONFIG_SYS_HYPERVISOR
-extern int hypervisor_init(void);
+extern int __must_check hypervisor_init(void);
 #else
 static inline int hypervisor_init(void) { return 0; }
 #endif
-extern int platform_bus_init(void);
-extern int system_bus_init(void);
-extern int cpu_dev_init(void);
-extern int attribute_container_init(void);
+extern int __must_check platform_bus_init(void);
+extern int __must_check system_bus_init(void);
+extern int __must_check cpu_dev_init(void);
+extern int __must_check attribute_container_init(void);
 
-extern int bus_add_device(struct device * dev);
-extern int bus_attach_device(struct device * dev);
+extern int __must_check bus_add_device(struct device * dev);
+extern int __must_check bus_attach_device(struct device * dev);
 extern void bus_remove_device(struct device * dev);
 extern struct bus_type *get_bus(struct bus_type * bus);
 extern void put_bus(struct bus_type * bus);
 
-extern int bus_add_driver(struct device_driver *);
+extern int __must_check bus_add_driver(struct device_driver *);
 extern void bus_remove_driver(struct device_driver *);
 
 extern void driver_detach(struct device_driver * drv);
-extern int driver_probe_device(struct device_driver *, struct device *);
+extern int __must_check driver_probe_device(struct device_driver *, struct device *);
 
 extern void sysdev_shutdown(void);
-extern int sysdev_suspend(pm_message_t state);
-extern int sysdev_resume(void);
+extern int __must_check sysdev_suspend(pm_message_t state);
+extern int __must_check sysdev_resume(void);
 
 static inline struct class_device *to_class_dev(struct kobject *obj)
 {