Skip to contentSkip to conversation

Fix menuconfig build failure due to missing stdbool.h

PATCH New Luca Tettamanti 1 participant 1 message Oct 9, 2006 Kconfig

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix menuconfig build failure due to missing stdbool.h

scripts/kconfig/lxdialog/util.c fails to build because it uses true/false without including stdbool.h:

kronos:~/src/linux-2.6$ make O=../linux-build-git menuconfig
  GEN     /home/kronos/src/linux-build/Makefile
  HOSTCC  scripts/kconfig/lxdialog/util.o
/home/kronos/src/linux-2.6/scripts/kconfig/lxdialog/util.c: In function 'set_classic_theme':
/home/kronos/src/linux-2.6/scripts/kconfig/lxdialog/util.c:68: error: 'true' undeclared (first use in this function)
/home/kronos/src/linux-2.6/scripts/kconfig/lxdialog/util.c:68: error: (Each undeclared identifier is reported only once
/home/kronos/src/linux-2.6/scripts/kconfig/lxdialog/util.c:68: error: for each function it appears in.)
/home/kronos/src/linux-2.6/scripts/kconfig/lxdialog/util.c:70: error: 'false' undeclared (first use in this function)
/home/kronos/src/linux-2.6/scripts/kconfig/lxdialog/util.c: In function 'set_blackbg_theme':
/home/kronos/src/linux-2.6/scripts/kconfig/lxdialog/util.c:101: error: 'true' undeclared (first use in this function)
/home/kronos/src/linux-2.6/scripts/kconfig/lxdialog/util.c:102: error: 'false' undeclared (first use in this function)
/home/kronos/src/linux-2.6/scripts/kconfig/lxdialog/util.c: In function 'set_bluetitle_theme':
/home/kronos/src/linux-2.6/scripts/kconfig/lxdialog/util.c:144: error: 'true' undeclared (first use in this function)
make[2]: *** [scripts/kconfig/lxdialog/util.o] Error 1
make[1]: *** [menuconfig] Error 2
make: *** [menuconfig] Error 2

Add <stdbool.h> to dialog.h to fix the breakage.

---
Patch against current git tree, tested with gcc-3.4, gcc-4.0 and gcc-4.1 from Debian/unstable.

Btw, the bug was introduced by this merge:

commit b4a9071af62f95dc6d22040a0b37ac7225ce4d54
Merge: 8b2a1fd... 99c8b94...
Author: Linus Torvalds <[email protected]>
Date: Tue Oct 3 08:51:38 2006 -0700

Merge git://git.kernel.org/pub/scm/linux/kernel/git/sam/kbuild

but I don't know how to extract the guilty commit from the merge...

scripts/kconfig/lxdialog/dialog.h +1 -0
index 8dea47f..fd695e1 100644
@@ -24,6 +24,7 @@ #include <unistd.h>
 #include <ctype.h>
 #include <stdlib.h>
 #include <string.h>
+#include <stdbool.h>
 
 #ifdef __sun__
 #define CURS_MACROS

Luca

Signature · 2 lines
La differenza fra l'intelligenza e la stupidita`?
All'intelligenza c'e` un limite.