firmware/dell_rbu: handle sysfs errors
PATCH 1/1 firmware/dell_rbu: handle sysfs errors
Signed-off-by Jeff Garzik <[email protected]>
---
drivers/firmware/dell_rbu.c | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-)
3ee9d835887cc49e747f3b39e7d8623918457e3d
drivers/firmware/dell_rbu.c +17 -4
@@ -718,14 +718,27 @@ static int __init dcdrbu_init(void)return -EIO ; } -sysfs_create_bin_file (&rbu_device->dev.kobj, &rbu_data_attr); -sysfs_create_bin_file (&rbu_device->dev.kobj, &rbu_image_type_attr); -sysfs_create_bin_file (&rbu_device->dev.kobj, + rc =sysfs_create_bin_file (&rbu_device->dev.kobj, &rbu_data_attr); +if (rc) + goto out_devreg; + rc =sysfs_create_bin_file (&rbu_device->dev.kobj, &rbu_image_type_attr); +if (rc) + goto out_data; + rc =sysfs_create_bin_file (&rbu_device->dev.kobj, &rbu_packet_size_attr); +if (rc) + goto out_imtype; rbu_data.entry_created =0 ; -return rc; +return 0 ; +out_imtype: +sysfs_remove_bin_file (&rbu_device->dev.kobj, &rbu_image_type_attr); +out_data: +sysfs_remove_bin_file (&rbu_device->dev.kobj, &rbu_data_attr); +out_devreg: +platform_device_unregister (rbu_device); +return rc; } static __exit void dcdrbu_exit(void)