Skip to contentSkip to conversation

firmware/dcdbas: fix bug in error cleanup

PATCH New Jeff Garzik 1 participant 1 message Oct 10, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 firmware/dcdbas: fix bug in error cleanup

The error path path mistakenly called sysfs_create_group() rather than sysfs_remove_group(). They take the same arguments, so it's easy to cut-n-paste such a bug.

---

 drivers/firmware/dcdbas.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

36ed9d7acc1c6df0c9f1083e1df729631339a3d8

drivers/firmware/dcdbas.c +1 -1
index 339f405..8bcb58c 100644
@@ -559,7 +559,7 @@ static int __devinit dcdbas_probe(struct
 			while (--i >= 0)
 				sysfs_remove_bin_file(&dev->dev.kobj,
 						      dcdbas_bin_attrs[i]);
-			sysfs_create_group(&dev->dev.kobj, &dcdbas_attr_group);
+			sysfs_remove_group(&dev->dev.kobj, &dcdbas_attr_group);
 			return error;
 		}
 	}