Skip to contentSkip to conversation

firmware/efivars: handle error

PATCH In review Jeff Garzik 2 participants 2 messages Oct 10, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 firmware/efivars: handle error

---

 drivers/firmware/efivars.c      |    7 ++++++-
drivers/firmware/efivars.c +6 -1
index 8ebce1c..5ab5e39 100644
@@ -639,7 +639,12 @@ efivar_create_sysfs_entry(unsigned long 
 
 	kobject_set_name(&new_efivar->kobj, "%s", short_name);
 	kobj_set_kset_s(new_efivar, vars_subsys);
-	kobject_register(&new_efivar->kobj);
+	i = kobject_register(&new_efivar->kobj);
+	if (i) {
+		kfree(short_name);
+		kfree(new_efivar);
+		return 1;
+	}
 
 	kfree(short_name);
 	short_name = NULL;
Acked-by on v1 1/1
#1 lore raw
	On Tue, Oct 10, 2006 at 09:19:49AM -0400, Jeff Garzik wrote:
Quoted 16 lines

---

 drivers/firmware/efivars.c      |    7 ++++++-
drivers/firmware/efivars.c +0 -0
index 8ebce1c..5ab5e39 100644
@@ -639,7 +639,12 @@ efivar_create_sysfs_entry(unsigned long 
 
 	kobject_set_name(&new_efivar->kobj, "%s", short_name);
 	kobj_set_kset_s(new_efivar, vars_subsys);

drivers/firmware/efivars.c efivar_create_sysfs_entry(unsigned long · line 650

Quoted 10 lines
drivers/firmware/efivars.c +6 -1
-	kobject_register(&new_efivar->kobj);
+	i = kobject_register(&new_efivar->kobj);
+	if (i) {
+		kfree(short_name);
+		kfree(new_efivar);
+		return 1;
+	}
 
 	kfree(short_name);
 	short_name = NULL;

Thanks Jeff!

Signature · 4 lines
Matt Domsch
Software Architect
Dell Linux Solutions linux.dell.com & www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com