fix sparc32 modpost warnings
PATCH 2/4 fix sparc32 modpost warnings
Fix these 2.6.19-rc1 build warnings from modpost:
WARNING: vmlinux - Section mismatch: reference to .init.data:boot_flags from .text between 'obp_system_intr' (at offset 0x12dd0) and 'show_cpuinfo'
WARNING: vmlinux - Section mismatch: reference to .init.data:boot_flags from .text between 'obp_system_intr' (at offset 0x12dd4) and 'show_cpuinfo'
Martin
---
Index: linux/arch/sparc/kernel/setup.c
=================================--- linux.orig/arch/sparc/kernel/setup.c 2006-10-06 01:08:29.000000000 +0100
+++ linux/arch/sparc/kernel/setup.c 2006-10-07 02:32:20.000000000 +0100
@@ -122,7 +122,7 @@
.index = -1,
};
-int obp_system_intr(void)
+int __init obp_system_intr(void)
{
if (boot_flags & BOOTME_DEBUG) {
printk("OBP: system interrupted\n");
From: Martin Habets <[email protected]>
Date: Tue, 10 Oct 2006 16:45:03 +0100
Quoted 3 lines
Fix these 2.6.19-rc1 build warnings from modpost:
WARNING: vmlinux - Section mismatch: reference to .init.data:boot_flags from .text between '
obp_system_intr' (at offset0x12dd0) and 'show_cpuinfo'
...
Review line 128
Quoted 12 lines
Index:
linux/arch/sparc/kernel/setup.c
=================================> ---linux.orig/arch/sparc/kernel/setup.c2006-10-06 01:08:29.000000000 +0100
+++linux/arch/sparc/kernel/setup.c2006-10-07 02:32:20.000000000 +0100(quoted diff) +1
-1@@ -122,7 +122,7 @@ .index = -1, }; -int obp_system_intr(void) +int __init obp_system_intr(void) { if (boot_flags & BOOTME_DEBUG) { printk("OBP: system interrupted\n");
This function isn't even referenced anywhere in the tree. We should just remove it, if anything.
I'll kill it from both sparc64 and sparc32, thanks.
Quoted 23 lines · David Miller
From: Martin Habets <[email protected]>
Date: Tue, 10 Oct 2006 16:45:03 +0100Quoted 3 lines
Fix these 2.6.19-rc1 build warnings from modpost:
WARNING: vmlinux - Section mismatch: reference to .init.data:boot_flags from .text between '
obp_system_intr' (at offset0x12dd0) and 'show_cpuinfo'...
Review line 128
Quoted 12 lines
Index:
linux/arch/sparc/kernel/setup.c
=================================> > ---linux.orig/arch/sparc/kernel/setup.c2006-10-06 01:08:29.000000000 +0100
+++linux/arch/sparc/kernel/setup.c2006-10-07 02:32:20.000000000 +0100(quoted diff) +1
-1@@ -122,7 +122,7 @@ .index = -1, }; -int obp_system_intr(void) +int __init obp_system_intr(void) { if (boot_flags & BOOTME_DEBUG) { printk("OBP: system interrupted\n");This function isn't even referenced anywhere in the tree. We should just remove it, if anything.
Quoted 1 line
I'll kill it from both sparc64 and sparc32, thanks.
Even better. Great!
Looking at this again it seems to me BOOTME_SINGLE and the '-s' flag is not used/working either. Should I make a patch to remove that?
Signature · 1 line
Martin
From: Martin Habets <[email protected]>
Date: Wed, 11 Oct 2006 17:14:05 +0100
Quoted 2 lines
Looking at this again it seems to me
BOOTME_SINGLEand the '-s' flag is not used/working either. Should I make a patch to remove that?
That would be great.