Skip to contentSkip to conversation

drivers/media/video/se401.c: check kmalloc() return value.

PATCH New Amit Choudhary 1 participant 1 message Oct 11, 2006 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 drivers/media/video/se401.c: check kmalloc() return value.

Description: Check the return value of kmalloc() in function se401_start_stream(), in file drivers/media/video/se401.c.

drivers/media/video/se401.c +11 -0
index 7aeec57..20b91db 100644
@@ -57,6 +57,7 @@ MODULE_PARM_DESC(flickerless, "Net frequ
 module_param(video_nr, int, 0);
 
 static struct usb_driver se401_driver;
+static int se401_stop_stream(struct usb_se401 *se401);
 
 
 /**********************************************************************
@@ -450,6 +451,11 @@ static int se401_start_stream(struct usb
 	}
 	for (i=0; i<SE401_NUMSBUF; i++) {
 		se401->sbuf[i].data=kmalloc(SE401_PACKETSIZE, GFP_KERNEL);
+		/* No memory, stop streaming */
+		if (!se401->sbuf[i].data) {
+			se401_stop_stream(se401);
+			return -ENOMEM;
+		}
 	}
 
 	se401->bayeroffset=0;
@@ -458,6 +464,11 @@ static int se401_start_stream(struct usb
 	se401->scratch_overflow=0;
 	for (i=0; i<SE401_NUMSCRATCH; i++) {
 		se401->scratch[i].data=kmalloc(SE401_PACKETSIZE, GFP_KERNEL);
+		/* No memory, stop streaming */
+		if (!se401->scratch[i].data) {
+			se401_stop_stream(se401);
+			return -ENOMEM;
+		}
 		se401->scratch[i].state=BUFFER_UNUSED;
 	}