Skip to contentSkip to conversation

d80211: remove initialization of unused xr structure members

PATCH In review David Kimdon 3 participants 3 messages Oct 13, 2006 – Oct 18, 2006

Subsystems (3)
Networking Network drivers Networking drivers (wireless)
lore
Share & tools
lore

David Kimdon

author
#0 lore raw

PATCH 1/1 d80211: remove initialization of unused xr structure members

The structure member xr_end was removed from d80211.h.

Signed-off-by David Kimdon <[email protected]>
drivers/net/wireless/d80211/rt2x00/rt2400pci.c +0 -5
Index: wireless-dev/drivers/net/wireless/d80211/rt2x00/rt2400pci.c
===================================================================
@@ -2704,11 +2704,6 @@ static int rt2400pci_init_hw_modes(struc
 	rt2400pci_init_hw_channels(rt2x00dev, hw->modes->channels);
 	rt2400pci_init_hw_rates(rt2x00dev, hw->modes->rates);
 
-	/*
-	 * xr_end is only used on Atheros cards.
-	 */
-	hw->modes->xr_end = 0;
-
 	return ieee80211_update_hw(net_dev, hw);
 
 exit_free_channels:
drivers/net/wireless/d80211/rt2x00/rt2500pci.c +0 -5
Index: wireless-dev/drivers/net/wireless/d80211/rt2x00/rt2500pci.c
===================================================================
@@ -2989,11 +2989,6 @@ static int rt2500pci_init_hw_modes(struc
 	rt2500pci_init_hw_channels(rt2x00dev, hw->modes[0].channels);
 	rt2500pci_init_hw_rates(rt2x00dev, hw->modes[0].rates);
 
-	/*
-	 * xr_end is only used on Atheros cards.
-	 */
-	hw->modes->xr_end = 0;
-
 	return ieee80211_update_hw(net_dev, hw);
 
 exit_free_channels:
drivers/net/wireless/d80211/rt2x00/rt61pci.c +0 -5
Index: wireless-dev/drivers/net/wireless/d80211/rt2x00/rt61pci.c
===================================================================
@@ -3501,11 +3501,6 @@ static int rt61pci_init_hw_modes(struct 
 	rt61pci_init_hw_channels(rt2x00dev, hw->modes[0].channels);
 	rt61pci_init_hw_rates(rt2x00dev, hw->modes[0].rates);
 
-	/*
-	 * xr_end is only used on Atheros cards.
-	 */
-	hw->modes->xr_end = 0;
-
 	return ieee80211_update_hw(net_dev, hw);
 
 exit_free_channels:

--

#1 lore raw
Quoted 1 line · David Kimdon

The structure member xr_end was removed from d80211.h.

John, please apply this after you pull from my tree (perhaps with a rt2x00 prefix in the subject instead of d80211?).

Thanks,

Jiri

Signature · 2 lines
Jiri Benc
SUSE Labs
#2 lore raw

Hi,

Quoted 4 lines
Quoted 1 line

The structure member xr_end was removed from d80211.h.

John, please apply this after you pull from my tree (perhaps with a rt2x00 prefix in the subject instead of d80211?).

The patch itself looked good, but it doesn't fix rt2500usb and rt73usb, I will send a patch to fix the rt2x00 USB drivers shortly.

Ivo