Skip to contentSkip to conversation

undefined reference to highest_possible_node_id

DISCUSSION Olaf Hering 3 participants 4 messages Oct 15, 2006

lore
Share & tools
lore
#0 lore raw

A 2.6.19-rc2 pseries_defconfig build with SMP=n will not link, highest_possible_node_id is undefined because NODES_SHIFT == 4. How can this be fixed properly?

#1 lore raw
Quoted 3 lines · Olaf Hering

A 2.6.19-rc2 pseries_defconfig build with SMP=n will not link, highest_possible_node_id is undefined because NODES_SHIFT == 4. How can this be fixed properly?

I noticed the same a few days ago, but only started looking into it a few minutes ago.

If MAX_NUMNODES is larger than one, highest_possible_node_id() is no longer a macro, but a real function, defined in lib/cpumask.c. NEED_MULTIPLE_NODES depends on DISCONTIGMEM || NUMA.

But lib/cpumask.c is compiled only for SMP, causing a link failure if CONFIG_SUNRPC is enabled, as net/sunrpc/svc.c:svc_pool_map_init_pernode() uses highest_possible_node_id().

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#2 lore raw
In reply to Olaf Hering
Quoted 4 lines · Olaf Hering

A 2.6.19-rc2 pseries_defconfig build with SMP=n will not link, highest_possible_node_id is undefined because NODES_SHIFT == 4. How can this be fixed properly?

This known bug in -mm [1] made it into Linus' tree?

It's not funny if more than a month after a bug report against -mm the bug is not only unfixed but even propagated to Linus' tree. :-(

cu
Adrian

[1] http://lkml.org/lkml/2006/9/4/233

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#3 lore raw
Quoted 6 lines · Adrian Bunk
Quoted 3 lines · Olaf Hering

A 2.6.19-rc2 pseries_defconfig build with SMP=n will not link, highest_possible_node_id is undefined because NODES_SHIFT == 4. How can this be fixed properly?

This known bug in -mm [1] made it into Linus' tree?

Yep, it got introduced in 2.6.19-rc1.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds