Skip to contentSkip to conversation

Clean up BACKTRACK().

PATCH Applied Ville Nuorvala 2 participants 2 messages Oct 17, 2006

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 4/13 Clean up BACKTRACK().

The fn check is unnecessary as fn can never be NULL in BACKTRACK().

---
 net/ipv6/route.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
net/ipv6/route.c +1 -1
index a1b0f07..263c057 100644
@@ -484,7 +484,7 @@ #define BACKTRACK(saddr) \
 do { \
 	if (rt == &ip6_null_entry) { \
 		struct fib6_node *pn; \
-		while (fn) { \
+		while (1) { \
 			if (fn->fn_flags & RTN_TL_ROOT) \
 				goto out; \
 			pn = fn->parent; \
Signature · 1 line
1.4.2.3
maintainer Applied
#1 lore raw

From: Ville Nuorvala <[email protected]>
Date: Tue, 17 Oct 2006 03:06:27 +0300

Quoted 3 lines

The fn check is unnecessary as fn can never be NULL in BACKTRACK().

Applied, especially valid since we're walking parents up to the, we break out at hitting root, and root's parent is itself :-)

Thanks.