Skip to contentSkip to conversation

BUG dcache.c:613 during autofs unmounting in 2.6.19rc2

DISCUSSION Andi Kleen 3 participants 8 messages Oct 16, 2006 – Oct 17, 2006

Subsystems (2)
lore
Share & tools
lore
maintainer
#1 lore raw
Quoted 10 lines · Andi Kleen

While unmounting autofs on shutdown my workstation got a dcache.c:613 BUG with 2.6.19rc2.

Only jpegs available unfortunately:

http://one.firstfloor.org/~andi/autofs-oops1.jpg
http://one.firstfloor.org/~andi/autofs-oops2.jpg

I think it was autofs3 instead of autofs4 - at least I got both compiled in. The autofs user land was autofs-4.1.4 (-6 suse rpm)

Don't think compiling both in is a good idea.
They both register as "autofs" so you really should choose one and disable the other.

For my part I have to recommend autofs4 (personally I'd like to see the autofs v3 module deprecated) and autofs4 is really needed if your using autofs version 4 or above.

Ian

author
#2 lore raw
Quoted 12 lines · Ian Kent
Quoted 10 lines · Andi Kleen

While unmounting autofs on shutdown my workstation got a dcache.c:613 BUG with 2.6.19rc2.

Only jpegs available unfortunately:

http://one.firstfloor.org/~andi/autofs-oops1.jpg
http://one.firstfloor.org/~andi/autofs-oops2.jpg

I think it was autofs3 instead of autofs4 - at least I got both compiled in. The autofs user land was autofs-4.1.4 (-6 suse rpm)

Quoted 7 lines

Don't think compiling both in is a good idea.
They both register as "autofs" so you really should choose one and disable the other.

For my part I have to recommend autofs4 (personally I'd like to see the autofs v3 module deprecated) and autofs4 is really needed if your using autofs version 4 or above.

Well it always worked this way in earlier kernels and even if the wrong module was suddenly used for some reason it shouldn't BUG. So something is broken.

-Andi

maintainer
#3 lore raw
Quoted 17 lines · Andi Kleen
Quoted 16 lines · Ian Kent
Quoted 10 lines · Andi Kleen

While unmounting autofs on shutdown my workstation got a dcache.c:613 BUG with 2.6.19rc2.

Only jpegs available unfortunately:

http://one.firstfloor.org/~andi/autofs-oops1.jpg
http://one.firstfloor.org/~andi/autofs-oops2.jpg

I think it was autofs3 instead of autofs4 - at least I got both compiled in. The autofs user land was autofs-4.1.4 (-6 suse rpm)

Don't think compiling both in is a good idea.
They both register as "autofs" so you really should choose one and disable the other.

Quoted 7 lines
Quoted 3 lines

For my part I have to recommend autofs4 (personally I'd like to see the autofs v3 module deprecated) and autofs4 is really needed if your using autofs version 4 or above.

Well it always worked this way in earlier kernels and even if the wrong module was suddenly used for some reason it shouldn't BUG. So something is broken.

True.

There have been some changes in this area (David Howells made some changes which affected autofs4) and I'm not sure that the autofs module was reviewed. I didn't look closely at it at the time, I guess I should have. Sorry.

It will take a while longer to work out if the autofs if open to the same issue resulting from Davids change.

Ian

maintainer
#4 lore raw
Quoted 6 lines · Ian Kent
Quoted 3 lines

Well it always worked this way in earlier kernels and even if the wrong module was suddenly used for some reason it shouldn't BUG. So something is broken.

True.

Quoted 7 lines

There have been some changes in this area (David Howells made some changes which affected autofs4) and I'm not sure that the autofs module was reviewed. I didn't look closely at it at the time, I guess I should have. Sorry.

It will take a while longer to work out if the autofs if open to the same issue resulting from Davids change.

Oh forgot .. I know it may be hard to do but could you try and confirm whether it was autofs or autofs4. They are very different and I don't want to stare at code trying to work out what's wrong if it's not broken.

Quoted 3 lines

Ian

#5 lore raw
In reply to Ian Kent
Quoted 4 lines · Ian Kent

There have been some changes in this area (David Howells made some changes which affected autofs4) and I'm not sure that the autofs module was reviewed. I didn't look closely at it at the time, I guess I should have. Sorry.

It looks like my fixes for autofs4 need applying to autofs also.

David

#6 lore raw

AUTOFS3: Make sure all dentries refs are released before calling kill_anon_super()

In reply to Andi Kleen

Make sure all dentries refs are released before calling kill_anon_super() so that the assumption that generic_shutdown_super() can completely destroy the dentry tree for there will be no external references holds true.

What was being done in the put_super() superblock op, is now done in the kill_sb() filesystem op instead, prior to calling kill_anon_super().

The call to shrink_dcache_sb() is removed as it is redundant since shrink_dcache_for_umount() will now be called after the cleanup routine.

---

 fs/autofs/autofs_i.h |    1 +
 fs/autofs/dirhash.c  |    1 -
 fs/autofs/init.c     |    2 +-
 fs/autofs/inode.c    |    4 ++--
 4 files changed, 4 insertions(+), 4 deletions(-)
fs/autofs/autofs_i.h +1 -0
index c7700d9..906ba5c 100644
@@ -149,6 +149,7 @@ extern const struct file_operations auto
 /* Initializing function */
 
 int autofs_fill_super(struct super_block *, void *, int);
+void autofs_kill_sb(struct super_block *sb);
 
 /* Queue management functions */
 
fs/autofs/dirhash.c +0 -1
index 3fded38..bf8c8af 100644
@@ -246,5 +246,4 @@ void autofs_hash_nuke(struct autofs_sb_i
 			kfree(ent);
 		}
 	}
-	shrink_dcache_sb(sbi->sb);
 }
fs/autofs/init.c +1 -1
index aca1237..cea5219 100644
@@ -24,7 +24,7 @@ static struct file_system_type autofs_fs
 	.owner		= THIS_MODULE,
 	.name		= "autofs",
 	.get_sb		= autofs_get_sb,
-	.kill_sb	= kill_anon_super,
+	.kill_sb	= autofs_kill_sb,
 };
 
 static int __init init_autofs_fs(void)
fs/autofs/inode.c +2 -2
index 2c9759b..54c518c 100644
@@ -20,7 +20,7 @@ #include <linux/magic.h>
 #include "autofs_i.h"
 #include <linux/module.h>
 
-static void autofs_put_super(struct super_block *sb)
+void autofs_kill_sb(struct super_block *sb)
 {
 	struct autofs_sb_info *sbi = autofs_sbi(sb);
 	unsigned int n;
@@ -37,13 +37,13 @@ static void autofs_put_super(struct supe
 	kfree(sb->s_fs_info);
 
 	DPRINTK(("autofs: shutting down\n"));
+	kill_anon_super(sb);
 }
 
 static void autofs_read_inode(struct inode *inode);
 
 static struct super_operations autofs_sops = {
 	.read_inode	= autofs_read_inode,
-	.put_super	= autofs_put_super,
 	.statfs		= simple_statfs,
 };
 
maintainer Acked-by
#7 lore raw

Re: AUTOFS3: Make sure all dentries refs are released before calling kill_anon_super()

Quoted 11 lines · David Howells

Make sure all dentries refs are released before calling kill_anon_super() so that the assumption that generic_shutdown_super() can completely destroy the dentry tree for there will be no external references holds true.

What was being done in the put_super() superblock op, is now done in the kill_sb() filesystem op instead, prior to calling kill_anon_super().

The call to shrink_dcache_sb() is removed as it is redundant since shrink_dcache_for_umount() will now be called after the cleanup routine.

Quoted 71 lines

---

 fs/autofs/autofs_i.h |    1 +
 fs/autofs/dirhash.c  |    1 -
 fs/autofs/init.c     |    2 +-
 fs/autofs/inode.c    |    4 ++--
 4 files changed, 4 insertions(+), 4 deletions(-)
fs/autofs/autofs_i.h +1 -0
index c7700d9..906ba5c 100644
@@ -149,6 +149,7 @@ extern const struct file_operations auto
 /* Initializing function */
 
 int autofs_fill_super(struct super_block *, void *, int);
+void autofs_kill_sb(struct super_block *sb);
 
 /* Queue management functions */
 
fs/autofs/dirhash.c +0 -1
index 3fded38..bf8c8af 100644
@@ -246,5 +246,4 @@ void autofs_hash_nuke(struct autofs_sb_i
 			kfree(ent);
 		}
 	}
-	shrink_dcache_sb(sbi->sb);
 }
fs/autofs/init.c +1 -1
index aca1237..cea5219 100644
@@ -24,7 +24,7 @@ static struct file_system_type autofs_fs
 	.owner		= THIS_MODULE,
 	.name		= "autofs",
 	.get_sb		= autofs_get_sb,
-	.kill_sb	= kill_anon_super,
+	.kill_sb	= autofs_kill_sb,
 };
 
 static int __init init_autofs_fs(void)
fs/autofs/inode.c +2 -2
index 2c9759b..54c518c 100644
@@ -20,7 +20,7 @@ #include <linux/magic.h>
 #include "autofs_i.h"
 #include <linux/module.h>
 
-static void autofs_put_super(struct super_block *sb)
+void autofs_kill_sb(struct super_block *sb)
 {
 	struct autofs_sb_info *sbi = autofs_sbi(sb);
 	unsigned int n;
@@ -37,13 +37,13 @@ static void autofs_put_super(struct supe
 	kfree(sb->s_fs_info);
 
 	DPRINTK(("autofs: shutting down\n"));
+	kill_anon_super(sb);
 }
 
 static void autofs_read_inode(struct inode *inode);
 
 static struct super_operations autofs_sops = {
 	.read_inode	= autofs_read_inode,
-	.put_super	= autofs_put_super,
 	.statfs		= simple_statfs,
 };