Skip to contentSkip to conversation

as fixes for Solaris

PATCH In review John Levon 2 participants 3 messages Oct 17, 2006

lore
Share & tools
lore

John Levon

author
#0 lore raw

PATCH 1/1 as fixes for Solaris

# HG changeset patch
# User [email protected]
# Date 1161090418 25200
# Node ID 8dcda57ee98a51ce528982a5f5d848e09584d08a
# Parent dff351e52952cc08be67ee5c7173c2c83167c15b
On sysv platforms, gas defaults '/' to a comment character. Pass in the right option to disable this behaviour, so Xen's semantics of "divide" apply.

config/SunOS.mk +2 -0
@@ -35,4 +35,6 @@ CFLAGS    += -g
 CFLAGS    += -g
 endif
 
+CAFLAGS = -Wa,--divide
+
 CONFIG_MBOOTPACK_OS = n
xen/Rules.mk +2 -2
@@ -99,10 +99,10 @@ _clean_%/: FORCE
 	$(MAKE) -f $(BASEDIR)/Rules.mk -C $* clean
 
 %.o: %.c $(HDRS) Makefile
-	$(CC) $(CFLAGS) -c $< -o $@
+	$(CC) $(CFLAGS) $(CAFLAGS) -c $< -o $@
 
 %.o: %.S $(HDRS) Makefile
-	$(CC) $(CFLAGS) $(AFLAGS) -c $< -o $@
+	$(CC) $(CFLAGS) $(CAFLAGS) $(AFLAGS) -c $< -o $@
 
 %.i: %.c $(HDRS) Makefile
 	$(CPP) $(CFLAGS) $< -o $@
#1 lore raw
Quoted 4 lines · John Levon

On sysv platforms, gas defaults '/' to a comment character. Pass in the right option to disable this behaviour, so Xen's semantics of "divide" apply.

Just fold this into your CFLAGS? I don't see a need for CAFLAGS.

-- Keir

author
#2 lore raw
Quoted 6 lines · Keir Fraser
Quoted 4 lines

On sysv platforms, gas defaults '/' to a comment character. Pass in the right option to disable this behaviour, so Xen's semantics of "divide" apply.

Just fold this into your CFLAGS? I don't see a need for CAFLAGS.

Fair enough.

# HG changeset patch
# User [email protected]
# Date 1161092306 25200
# Node ID edef190b7c8f296262dcc8cafa26a67664273a10
# Parent c62830316465c3d626c4790dfca92909e273e144
On sysv platforms, gas defaults '/' to a comment character. Pass in the right option to disable this behaviour, so Xen's semantics of "divide" apply.

config/SunOS.mk +2 -0
@@ -35,4 +35,6 @@ CFLAGS    += -g
 CFLAGS    += -g
 endif
 
+CFLAGS += -Wa,--divide
+
 CONFIG_MBOOTPACK_OS = n