Skip to contentSkip to conversation

implicit declaration of function set_irq_chip_and_handler

PATCH New Olaf Hering 2 participants 2 messages Oct 18, 2006 IRQ

lore
Share & tools
lore
#0 lore raw

Current Linus tree has two new warnings

arch/powerpc/kernel/irq.c: In function irq_dispose_mapping:
arch/powerpc/kernel/irq.c:642: warning: implicit declaration of function set_irq_chip_and_handler arch/powerpc/sysdev/mpic.c: In function mpic_host_map:
arch/powerpc/sysdev/mpic.c:770: warning: implicit declaration of function set_irq_chip_and_handler

It links anyway for some reason.
There is no prototype anymore, but still many users.

a460e745e8f9c75a0525ff94154a0629f9d3e05d is likely the culprit:
[PATCH] genirq: clean up irq-flow-type naming

#1 lore raw

PATCH 1/1 genirq: clean up irq-flow-type naming, fix

Quoted 4 lines · Olaf Hering

There is no prototype anymore, but still many users.

a460e745e8f9c75a0525ff94154a0629f9d3e05d is likely the culprit:
[PATCH] genirq: clean up irq-flow-type naming

oops, that was unintended. The patch below should fix this.

Ingo

--------------->
Subject: genirq: clean up irq-flow-type naming, fix
From: Ingo Molnar <[email protected]>

re-add the set_irq_chip_and_handler() prototype, it's still widely used.

---
 include/linux/irq.h |    3 +++
 1 file changed, 3 insertions(+)
include/linux/irq.h +3 -0
Index: linux/include/linux/irq.h
===================================================================
@@ -322,6 +322,9 @@ extern struct irq_chip no_irq_chip;
 extern struct irq_chip dummy_irq_chip;
 
 extern void
+set_irq_chip_and_handler(unsigned int irq, struct irq_chip *chip,
+			 irq_flow_handler_t handle);
+extern void
 set_irq_chip_and_handler_name(unsigned int irq, struct irq_chip *chip,
 			      irq_flow_handler_t handle, const char *name);