Skip to contentSkip to conversation

Disable DSPGW fails

DISCUSSION Dirk Behme 3 participants 4 messages Oct 4, 2006 – Oct 19, 2006

Subsystems (2)
lore
Share & tools
lore

Dirk Behme

author
#0 lore raw

Hi,

while debugging the OSK issue, I tried to disable DSPGW completely (CONFIG_OMAP_DSP is not set). On most recent git this fails with

arch/arm/plat-omap/built-in.o: In function `omap_mcbsp_free':
mcbsp.c:(.text+0x44b8): undefined reference to omap_dsp_release_mem' arch/arm/plat-omap/built-in.o: In function omap_mcbsp_request':
mcbsp.c:(.text+0x45cc): undefined reference to `omap_dsp_request_mem'

Anybody with an idea how to fix this?

Best regards

Dirk

#1 lore raw
Quoted 4 lines · Dirk Behme

while debugging the OSK issue, I tried to disable DSPGW completely (CONFIG_OMAP_DSP is not set). On most recent git this fails with

Quoted 8 lines

arch/arm/plat-omap/built-in.o: In function `omap_mcbsp_free':
mcbsp.c:(.text+0x44b8): undefined reference to `omap_dsp_release_mem'
arch/arm/plat-omap/built-in.o: In function `omap_mcbsp_request':
mcbsp.c:(.text+0x45cc): undefined reference to `omap_dsp_request_mem'

Anybody with an idea how to fix this?

Attached patch fix it. Feel free to push it into correct maintainer to get it included in GIT tree.

Signature · 4 lines
JID: hrw-jabber.org
OpenEmbedded developer

             Today is the first day of the rest of your life.

while debugging the OSK issue, I tried to disable DSPGW completely (CONFIG_OMAP_DSP is not set).

On most recent git this fails with

arch/arm/plat-omap/built-in.o: In function `omap_mcbsp_free':
mcbsp.c:(.text+0x44b8): undefined reference to `omap_dsp_release_mem'
arch/arm/plat-omap/built-in.o: In function `omap_mcbsp_request':
mcbsp.c:(.text+0x45cc): undefined reference to `omap_dsp_request_mem'

This patch fixes it.

arch/arm/plat-omap/mcbsp.c 2006-09-27 12:17:01.000000000 +0200 renamed from arch/arm/plat-omap/mcbsp.c 2006-09-27 12:17:21.000000000 +0200 +4 -0
Index: git/arch/arm/plat-omap/mcbsp.c
===================================================================
@@ -197,7 +197,9 @@
 static void omap_mcbsp_dsp_request(void)
 {
        if (cpu_is_omap15xx() || cpu_is_omap16xx()) {
+#ifdef CONFIG_OMAP_DSP
                omap_dsp_request_mem();
+#endif
                clk_enable(mcbsp_dsp_ck);
                clk_enable(mcbsp_api_ck);
 
@@ -216,7 +218,9 @@
 static void omap_mcbsp_dsp_free(void)
 {
        if (cpu_is_omap15xx() || cpu_is_omap16xx()) {
+#ifdef CONFIG_OMAP_DSP
                omap_dsp_release_mem();
+#endif
                clk_disable(mcbsp_dspxor_ck);
                clk_disable(mcbsp_dsp_ck);
                clk_disable(mcbsp_api_ck);
#2 lore raw

Hi,

Quoted 58 lines · Marcin Juszkiewicz
Quoted 4 lines · Dirk Behme

while debugging the OSK issue, I tried to disable DSPGW completely (CONFIG_OMAP_DSP is not set). On most recent git this fails with

Quoted 8 lines

arch/arm/plat-omap/built-in.o: In function `omap_mcbsp_free':
mcbsp.c:(.text+0x44b8): undefined reference to `omap_dsp_release_mem'
arch/arm/plat-omap/built-in.o: In function `omap_mcbsp_request':
mcbsp.c:(.text+0x45cc): undefined reference to `omap_dsp_request_mem'

Anybody with an idea how to fix this?

Attached patch fix it. Feel free to push it into correct maintainer to get it included in GIT tree.

Signature · 25 lines
JID: hrw-jabber.org
OpenEmbedded developer

             Today is the first day of the rest of your life.


while debugging the OSK issue, I tried to disable DSPGW 
completely (CONFIG_OMAP_DSP is not set). 

On most recent git this fails with

arch/arm/plat-omap/built-in.o: In function `omap_mcbsp_free':
mcbsp.c:(.text+0x44b8): undefined reference to 
`omap_dsp_release_mem'
arch/arm/plat-omap/built-in.o: In function `omap_mcbsp_request':
mcbsp.c:(.text+0x45cc): undefined reference to 
`omap_dsp_request_mem'

This patch fixes it.

Signed-off-by: Marcin Juszkiewicz <[email protected]>


Index: git/arch/arm/plat-omap/mcbsp.c
===================================================================
arch/arm/plat-omap/mcbsp.c 2006-09-27 12:17:01.000000000 +0200 renamed from arch/arm/plat-omap/mcbsp.c 2006-09-27 12:17:21.000000000 +0200 +2 -0
@@ -197,7 +197,9 @@
 static void omap_mcbsp_dsp_request(void)
 {
        if (cpu_is_omap15xx() || cpu_is_omap16xx()) {
+#ifdef CONFIG_OMAP_DSP
                omap_dsp_request_mem();
+#endif
                clk_enable(mcbsp_dsp_ck);
                clk_enable(mcbsp_api_ck);
 

arch/arm/plat-omap/mcbsp.c 2006-09-27 12:17:01.000000000 +0200 line 226

Quoted 9 lines
arch/arm/plat-omap/mcbsp.c 2006-09-27 12:17:01.000000000 +0200 renamed from arch/arm/plat-omap/mcbsp.c 2006-09-27 12:17:21.000000000 +0200 +2 -0
@@ -216,7 +218,9 @@
 static void omap_mcbsp_dsp_free(void)
 {
        if (cpu_is_omap15xx() || cpu_is_omap16xx()) {
+#ifdef CONFIG_OMAP_DSP
                omap_dsp_release_mem();
+#endif
                clk_disable(mcbsp_dspxor_ck);
                clk_disable(mcbsp_dsp_ck);
                clk_disable(mcbsp_api_ck);

This patch disables using McBSP without CONFIG_OMAP_DSP. I've posted another patch that should keep the old functionality, can you please try that out?

Regards,

Tony

#3 lore raw
Quoted 3 lines · Tony Lindgren

This patch disables using McBSP without CONFIG_OMAP_DSP. I've posted another patch that should keep the old functionality, can you please try that out?

My patch was made to get kernel built at all. Then Philip Balister changed default configuration so we did not have this problem again. I do not have board to test kernel.

Signature · 2 lines
JID: hrw-jabber.org
OpenEmbedded developer/consultant