Skip to contentSkip to conversation

Fixed stv0299 driver to use time_after instead of comparisons

PATCH New David KOENIG 1 participant 1 message Oct 20, 2006

Subsystems (2)
Media (V4L/DVB) Kernel janitors
lore
Share & tools
lore

David KOENIG

author
#0 lore raw

PATCH 1/1 Fixed stv0299 driver to use time_after instead of comparisons

From 914ba26e82ade62ca88ffa986fc06b4c0fb7a215 Mon Sep 17 00:00:00 2001
From: David KOENIG <[email protected]>
Date: Thu, 19 Oct 2006 19:38:26 -0700
Subject: [PATCH] Fixed stv0299 driver to use time_after instead of comparisons

---
 drivers/media/dvb/frontends/stv0299.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/drivers/media/dvb/frontends/stv0299.c
index 9348376..ff4da5a 100644

drivers/media/dvb/frontends/stv0299.c +3 -2
@@ -43,6 +43,7 @@
 */
 
 #include <linux/init.h>
+#include <linux/jiffies.h>
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/moduleparam.h>

@@ -193,7 +194,7 @@ static int stv0299_wait_diseqc_fifo (str
 	dprintk ("%s\n", __FUNCTION__);
 
 	while (stv0299_readreg(state, 0x0a) & 1) {
-		if (jiffies - start > timeout) {
+		if (time_after(jiffies, start + timeout)) {
 			dprintk ("%s: timeout!!\n", __FUNCTION__);
 			return -ETIMEDOUT;
 		}

@@ -210,7 +211,7 @@ static int stv0299_wait_diseqc_idle (str
 	dprintk ("%s\n", __FUNCTION__);
 
 	while ((stv0299_readreg(state, 0x0a) & 3) != 2 ) {
-		if (jiffies - start > timeout) {
+		if (time_after(jiffies, start + timeout)) {
 			dprintk ("%s: timeout!!\n", __FUNCTION__);
 			return -ETIMEDOUT;
 		}
Signature · 10 lines
1.4.1


-- 
<>< [email protected]

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors