Skip to contentSkip to conversation

Updates NAND Flash controller support in PPC 440 EP/GR/x

PATCH New Jeff Mann 2 participants 3 messages Oct 18, 2006 – Oct 21, 2006

lore
Share & tools
lore

Jeff Mann

author
#0 lore raw

PATCH 1/1 Updates NAND Flash controller support in PPC 440 EP/GR/x

Stefan:

Quoted 1 line

Please give the attached version a try and let me know if it works for

you. If nobody objects this will go into the official tree soon.

It looks good, but I see one minor problem: in nand_init(...) in drivers/nand/nand.c, nand_curr_device is set to the first nand device that is found. In the nand flash controller driver board_nand_init(...), the chip select is set. So after two or more devices are found, the chip select is left set to the last device while nand_curr_device is set for the first. A call to board_nand_select_device(...) is needed at the end of nand_init(...) to set the chip selects correctly.

-Jeff

#1 lore raw

PATCH 1/1 Updates NAND Flash controller support in PPC 440 EP/GR/x

Hi Jeff,

Quoted 7 lines · Jeff Mann

It looks good, but I see one minor problem: in nand_init(...) in drivers/nand/nand.c, nand_curr_device is set to the first nand device that is found. In the nand flash controller driver board_nand_init(...), the chip select is set. So after two or more devices are found, the chip select is left set to the last device while nand_curr_device is set for the first. A call to board_nand_select_device(...) is needed at the end of nand_init(...) to set the chip selects correctly.

Yes, I overlooked this. Thanks. I'll update the code and commit in the next few days.

Best regards,
Stefan

Applied
#2 lore raw

PATCH 1/1 Updates NAND Flash controller support in PPC 440 EP/GR/x

Quoted 2 lines · Stefan Roese

Yes, I overlooked this. Thanks. I'll update the code and commit in the next few days.

Applied. Thanks.

Best regards,
Stefan