2.6.19-rc2-mm2 not building on ia64
We're seeing the following error building the 2.6.19-rc2-mm2 kernel on ia64 (it builds ok on x86_64). 2.6.19-rc2-git4 builds ok.
CC [M] drivers/acpi/processor_throttling.oarch/ia64/sn/kernel/setup.c: In function `sn_setup':arch/ia64/sn/kernel/setup.c:470: error: `ia64_timestamp_clock' undeclared (first use in this function) arch/ia64/sn/kernel/setup.c:470: error: (Each undeclared identifier is reported only once arch/ia64/sn/kernel/setup.c:470: error: for each function it appears in.)
CC fs/ext2/namei.o
make[2]: *** [arch/ia64/sn/kernel/setup.o] Error 1
make[1]: *** [arch/ia64/sn/kernel] Error 2
make: *** [arch/ia64/sn] Error 2
make: *** Waiting for unfinished jobs....
Full logs:
http://crucible.osdl.org/runs/2688/logs/ita01/kernel.config.log
http://crucible.osdl.org/runs/2688/logs/ita01/kernel.make.log
Config file:
http://crucible.osdl.org/runs/2688/sysinfo/ita01.config
Bryce
Quoted 4 lines · Bryce Harrington
We're seeing the following error building the 2.6.19-rc2-mm2 kernel on ia64 (it builds ok on
x86_64). 2.6.19-rc2-git4 builds ok.
CC [M]drivers/acpi/processor_throttling.oarch/ia64/sn/kernel/setup.c: In function `sn_setup':
Quoted 8 lines
arch/ia64/sn/kernel/setup.c:470: error: `ia64_timestamp_clock' undeclared (first use in this function)arch/ia64/sn/kernel/setup.c:470: error: (Each undeclared identifier is reported only oncearch/ia64/sn/kernel/setup.c:470: error: for each function it appears in.)
CCfs/ext2/namei.o
make[2]: *** [arch/ia64/sn/kernel/setup.o] Error 1
make[1]: *** [arch/ia64/sn/kernel] Error 2
make: *** [arch/ia64/sn] Error 2
make: *** Waiting for unfinished jobs....
(added relevant CCs)
This is caused by statistics-infrastructure-make-printk_clock-a-generic-kernel-wide-nsec-resolution.patch
I wonder how this could ever compile :)
Andrew, could you please apply this trivial on top of the original one?
[PATCH] IA64: Fix compile problem in arch/ia64/sn/setup.c
Rename forgotten occurence of ia64_printk_clock to ia64_timestamp_clock
---
arch/ia64/sn/kernel/setup.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/ia64/sn/kernel/setup.c +1 -1
@@ -65,7 +65,7 @@ extern void sn_timer_init(void);extern unsigned long last_time_offset;extern void (*ia64_mark_idle) (int );extern void snidle (int ); -extern unsigned long long (*ia64_printk_clock)(void ); +extern unsigned long long (*ia64_timestamp_clock)(void );unsigned long sn_rtc_cycles_per_second;EXPORT_SYMBOL (sn_rtc_cycles_per_second);
Signature · 1 line
Jiri Kosina
Quoted 15 lines · On Sat, 21 Oct 2006 00:14:34 +0200 (CEST) Jiri Kosina <[email protected]> wrote:
Quoted 4 lines · Bryce Harrington
We're seeing the following error building the 2.6.19-rc2-mm2 kernel on ia64 (it builds ok on
x86_64). 2.6.19-rc2-git4 builds ok.
CC [M]drivers/acpi/processor_throttling.oarch/ia64/sn/kernel/setup.c: In function `sn_setup':Quoted 8 lines
arch/ia64/sn/kernel/setup.c:470: error: `ia64_timestamp_clock' undeclared (first use in this function)arch/ia64/sn/kernel/setup.c:470: error: (Each undeclared identifier is reported only oncearch/ia64/sn/kernel/setup.c:470: error: for each function it appears in.)
CCfs/ext2/namei.o
make[2]: *** [arch/ia64/sn/kernel/setup.o] Error 1
make[1]: *** [arch/ia64/sn/kernel] Error 2
make: *** [arch/ia64/sn] Error 2
make: *** Waiting for unfinished jobs....
Quoted 6 lines
(added relevant CCs)
This is caused by statistics-infrastructure-make-printk_clock-a-generic-kernel-wide-nsec-resolution.patch
I wonder how this could ever compile :)
grr. How many times do we have to tell how many people to not put extern declarations in C files? This build error is a direct consequence of that absolutely utterly basic programming mistake.
Quoted 1 line
Andrew, could you please apply this trivial on top of the original one?
If I had the energy I'd fix it for real, but I don't so I won't. Thanks.