McBSP dependence for DSP on ARCH_OMAP1 is missing
Subsystems (2)
PATCH 1/1 McBSP dependence for DSP on ARCH_OMAP1 is missing
Hi,
I've tried to compile an up-to-dated kernel tree configured for h3. I got some errors due to the McBSP depends on OMAP_DSP if ARCH_OMAP1 is set, as we can see at these lines from "arch/arm/plat-omap/mcbsp.c":
(...)
#ifdef CONFIG_ARCH_OMAP1
static void omap_mcbsp_dsp_request(void)
{
if (cpu_is_omap15xx() || cpu_is_omap16xx()) {
omap_dsp_request_mem();(...)
#endif
(...)
So, I've made this minimal patch to deal with this problem. It worked well for me. But I put, also, CONFIG_OMAP_DSP=y as default on h3 config file to keep the OMAP_MCBSP as default too.
BR,
David Cohen
---
arch/arm/configs/omap_h3_1710_defconfig +1 -1
@@ -136,7 +136,7 @@ CONFIG_OMAP_ARM_168MHZ=y # CONFIG_OMAP_ARM_120MHZ is not set # CONFIG_OMAP_ARM_60MHZ is not set # CONFIG_OMAP_ARM_30MHZ is not set -# CONFIG_OMAP_DSP is not set +CONFIG_OMAP_DSP=y # # Processor Type
arch/arm/plat-omap/Kconfig +1 -1
@@ -103,7 +103,7 @@ config OMAP_STI_CONSOLE config OMAP_MCBSP bool "McBSP support" - depends on ARCH_OMAP + depends on (ARCH_OMAP1 && OMAP_DSP) || ARCH_OMAP2 default y help Say Y here if you want support for the OMAP Multichannel
Quoted 13 lines · David Cohen
Hi,
I've tried to compile an up-to-dated kernel tree configured for h3. I got some errors due to the McBSP depends on
OMAP_DSPifARCH_OMAP1is set, as we can see at these lines from "arch/arm/plat-omap/mcbsp.c":(...)
#ifdefCONFIG_ARCH_OMAP1
static voidomap_mcbsp_dsp_request(void){ if (cpu_is_omap15xx() || cpu_is_omap16xx()) { omap_dsp_request_mem();
Quoted 7 lines
(...)
#endif
(...)So, I've made this minimal patch to deal with this problem. It worked well for me. But I put, also,
CONFIG_OMAP_DSP=yas default on h3 config file to keep theOMAP_MCBSPas default too.
This should be already fixed in a recent patch:
Regards,
Tony