Skip to contentSkip to conversation

fix RARP ic_servaddr breakage

PATCH Applied Al Viro 2 participants 2 messages Oct 24, 2006

Subsystems (2)
lore
Share & tools
lore

Al Viro

author
#0 lore raw

PATCH 1/1 fix RARP ic_servaddr breakage

memcpy 4 bytes to address of auto unsigned long variable followed by comparison with u32 is a bloody bad idea.

---
 net/ipv4/ipconfig.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
net/ipv4/ipconfig.c +1 -1
index f8ce847..955a07a 100644
@@ -420,7 +420,7 @@ ic_rarp_recv(struct sk_buff *skb, struct
 {
 	struct arphdr *rarp;
 	unsigned char *rarp_ptr;
-	unsigned long sip, tip;
+	u32 sip, tip;
 	unsigned char *sha, *tha;		/* s for "source", t for "target" */
 	struct ic_device *d;
 
Signature · 1 line
1.4.2.GIT