Skip to contentSkip to conversation

: patch-backlog, bug-fixes, some code simplifications

PATCH In review Gerrit Renker 3 participants 6 messages Oct 24, 2006 – Oct 26, 2006

lore
Share & tools
lore
#0 lore raw

cover : patch-backlog, bug-fixes, some code simplifications

As promised earlier, this is the set of patches which I have been keeping up-to-date; they divide into:

* patches sent to this list that have not been merged [I claim that this is exhaustive, i.e. all other patches have been merged - notify me if there is one missing]
* bug fixes
* `cosmetic' patches to simplify and consolidate code

The set is consistent in itself and patches on top of the latest davem-2.6 tree, but: all are stacked, i.e. the best way of applying is

for p in $patches; do git-apply < $p; done

There are no new files introduced, so this works without problem. I have put in extra time to check / tidy each and every one. I hope that this will pay off, as I have little benefit from this and had to take this time away from other commitments.

Gerrit

#1 lore raw
Quoted 12 lines · Gerrit Renker

As promised earlier, this is the set of patches which I have been keeping up-to-date; they divide into:

* patches sent to this list that have not been merged [I claim that this is exhaustive, i.e. all other patches have been merged - notify me if there is one missing]
* bug fixes
* `cosmetic' patches to simplify and consolidate code

The set is consistent in itself and patches on top of the latest davem-2.6 tree, but: all are stacked, i.e. the best way of applying is

Quoted 6 lines

for p in $patches; do git-apply < $p; done

There are no new files introduced, so this works without problem. I have put in extra time to check / tidy each and every one. I hope that this will pay off, as I have little benefit from this and had to take this time away from other commitments.

Thanks a lot for this Gerrit, now I have a work related meeting, but later today I'll try and review these patches and get them into a net-2.6.20 tree

- Arnaldo

#2 lore raw
In reply to Gerrit Renker
Quoted 7 lines · Gerrit Renker

There are no new files introduced, so this works without problem. I have put in extra time to check / tidy each and every one. I hope that this will pay off, as I have little benefit from this and had to take this time away from other commitments.

Gerrit

This looks great Gerrit. Thanks for your effort.

Ian

Signature · 7 lines
Ian McDonald
Web: http://wand.net.nz/~iam4
Blog: http://imcdnzl.blogspot.com
WAND Network Research Group
Department of Computer Science
University of Waikato
New Zealand
#3 lore raw
In reply to Gerrit Renker

Hi Arnaldo

|  Gerrit, now I have a work related meeting, but later today I'll 
|  try and review these patches and get them into a 
|  net-2.6.20 tree

Given that you are busy (as we know), I have set up the following to make things simpler and avoid getting into the same situation:

* I uploaded all patches from yesterday on to
http://www.erg.abdn.ac.uk/users/gerrit/dccp/patch-backlog/

* there is a `series' file to use with stgit/quilt; otherwise, for i in $(<series); do git apply < $i; done

* only patches submitted onto the list will be put there

* daily update since it is from my repository

* future submissions (whether from me or anyone else) will be added

* all keep the original signed-off lines and descriptions at top

* the whole lot (series and patches) can be downloaded as:
http://www.erg.abdn.ac.uk/users/gerrit/dccp/patch-backlog/the_whole_lot.tar.gz

This is probably simpler than pulling an entire tree, but if you prefer that, let me know.

Gerrit

#4 lore raw
In reply to Gerrit Renker

To make good on the claim that the backlog is exhaustive, I have gone through the past postings and can only identify the following, i.e. a single really outstanding patch under (3):

1) Patches which seem to be experimental:
-----------------------------------------

	* Experimental support for tcp_congestion_ops: 
          http://www.mail-archive.com/[email protected]/msg00425.html
	* CCID 2 profiling
	  http://www.mail-archive.com/[email protected]/msg00375.html
	* Shift constants into header
	  http://www.mail-archive.com/[email protected]/msg00520.html

2) Patches which have been withdrawn:
-------------------------------------

	* Always log debug messages when CONFIG_DEBUG is set
	  http://www.mail-archive.com/[email protected]/msg00580.html
           -- this was an RFC version, please do not regard 
	* Remove socket option / fix setting of packet size in CCID3 / 2 new sockopts [5..7/7]
		http://www.mail-archive.com/[email protected]/msg00521.html
		http://www.mail-archive.com/[email protected]/msg00522.html
		http://www.mail-archive.com/[email protected]/msg00523.html
	   -- merge request was withdrawn on 
	      http://www.mail-archive.com/[email protected]/msg00591.html

-- a strategy was discussed on
http://www.mail-archive.com/[email protected]/msg00581.html
... but no time so far to get down to the code !

3) Patches that are outstanding and have not been archived in the backlog:
--------------------------------------------------------------------------
* DCCP conntrack/NAT on

          http://www.mail-archive.com/[email protected]/msg00108.html

If anything has been omitted despite quite thorough efforts, please notify.

When new stuff gets posted, I will put it up on http://www.erg.abdn.ac.uk/users/gerrit/dccp/patch-backlog/ ; when a patch is removed via discussion, it will likewise be removed from there. All subsequent patches will be on top of the last one in the archive.

Gerrit

#5 lore raw
In reply to Gerrit Renker
Quoted 23 lines · Gerrit Renker

Hi Arnaldo

|  Gerrit, now I have a work related meeting, but later today I'll
|  try and review these patches and get them into a
|  net-2.6.20 tree

Given that you are busy (as we know), I have set up the following to make things simpler and avoid getting into the same situation:

* I uploaded all patches from yesterday on to
http://www.erg.abdn.ac.uk/users/gerrit/dccp/patch-backlog/

* there is a `series' file to use with stgit/quilt; otherwise, for i in $(<series); do git apply < $i; done

* only patches submitted onto the list will be put there

* daily update since it is from my repository

* future submissions (whether from me or anyone else) will be added

* all keep the original signed-off lines and descriptions at top

Quoted 7 lines

* the whole lot (series and patches) can be downloaded as:
http://www.erg.abdn.ac.uk/users/gerrit/dccp/patch-backlog/the_whole_lot.tar.gz

This is probably simpler than pulling an entire tree, but if you prefer that, let me know.

Gerrit

Really, really helpful Gerrit. Owe you some beers when we eventually meet at some conference. (As well as owing Arnaldo, Andrea et al beer for their efforts as well!)

Ian

Signature · 7 lines
Ian McDonald
Web: http://wand.net.nz/~iam4
Blog: http://imcdnzl.blogspot.com
WAND Network Research Group
Department of Computer Science
University of Waikato
New Zealand