add-process_session-helper-routine-deprecate-old-field-tidy
PATCH 1/1 add-process_session-helper-routine-deprecate-old-field-tidy
Review
Quoted 4 lines · Cedric Le Goater
(quoted diff) +2
-1- .session = 1, \ + .tty_old_pgrp = 0, \ + { .session = 1}, \
Any reason to initialize .tty_old_pgrp explicitly? This gives a false positive from grep...
include/linux/init_task.h renamed from include/linux/init_task.h~ +1 -2
@@ -66,8 +66,7 @@ .cpu_timers = INIT_CPU_TIMERS(sig.cpu_timers), \ .rlim = INIT_RLIMITS, \ .pgrp = 1, \ - .tty_old_pgrp = 0, \ - { .__session = 1}, \ + { .__session = 1 }, \ }extern struct nsproxy init_nsproxy;
Quoted 7 lines · Oleg Nesterov
Review
Quoted 3 lines · Cedric Le Goater
(quoted diff) +2
-1- .session = 1, \ + .tty_old_pgrp = 0, \ + { .session = 1}, \Any reason to initialize .tty_old_pgrp explicitly? This gives a false positive from grep...
it helps some version of gcc to find the anonymous union. I need to dig this issue a little bit more.
thanks,
C.