Skip to contentSkip to conversation

Fix reference counting in __find_device_hash_cell()

PATCH New Jan Blunck 1 participant 1 message Oct 26, 2006 Device mapper

lore
Share & tools
lore

Jan Blunck

author
#0 lore raw

PATCH 1/1 Fix reference counting in __find_device_hash_cell()

When the device is created but it hasn't yet been inserted into the hash list a concurrent call to __find_device_hash_cell() was failing to release the reference to the mapped device.

---
 drivers/md/dm-ioctl.c |    2 ++
 1 file changed, 2 insertions(+)
drivers/md/dm-ioctl.c +2 -0
Index: linux-2.6.18/drivers/md/dm-ioctl.c
===================================================================
@@ -608,6 +608,8 @@ static struct hash_cell *__find_device_h
 	md = dm_get_md(huge_decode_dev(param->dev));
 	if (md)
 		mdptr = dm_get_mdptr(md);
+	if (md && !mdptr)
+		dm_put(md);
 
 	return mdptr;
 }