Skip to contentSkip to conversation

silence 'make xmldocs' warning by adding missing description of 'raw' in nand_base.c:1485

PATCH Randy Dunlap 2 participants 2 messages Oct 27, 2006 – Oct 28, 2006 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 24 lines · On Fri, 27 Oct 2006 22:59:03 GMT Linux Kernel Mailing List wrote:

commit efbfe96c5d839c367249bf1cd53249716450c0a2
tree 36a1a7d72586a2f8fd25feb225cd4e627cd275b3
parent 735a7ffb739b6efeaeb1e720306ba308eaaeb20e
author Jesper Juhl <[email protected]> 1161984287 +0200 committer Linus Torvalds <[email protected]> 1161988491 -0700

[PATCH] silence 'make xmldocs' warning by adding missing description of 'raw' in nand_base.c:1485

Add description of 'raw' in comments for drivers/mtd/nand/nand_base.c::nand_write_page_syndrome() so 'make xmldocs' will not spew a warning at us.

 drivers/mtd/nand/nand_base.c |    1 +
 1 file changed, 1 insertion(+)
drivers/mtd/nand/nand_base.c +0 -0
index baece61..41bfcae 100644

drivers/mtd/nand/nand_base.c static void nand_write_page_syndrome(str

Quoted 8 lines
drivers/mtd/nand/nand_base.c +1 -1
@@ -1479,6 +1479,7 @@ static void nand_write_page_syndrome(str
  * @buf:	the data to write
  * @page:	page number to write
  * @cached:	cached programming
+ * @raw:	use _raw version of write_page
  */
 static int nand_write_page(struct mtd_info *mtd, struct nand_chip *chip,
 			   const uint8_t *buf, int page, int cached, int raw)
-

Hi Jesper,
I'm still seeing a kernel-doc warning in include/linux/mtd/nand.h. Do you not see it also?

Patch is here:
http://marc.theaimsgroup.com/?l=linux-mm-commits&m=116189778426861&w=2

---
~Randy

#2 lore raw
Quoted 30 lines · Randy Dunlap
Quoted 28 lines · On Fri, 27 Oct 2006 22:59:03 GMT Linux Kernel Mailing List wrote:

commit efbfe96c5d839c367249bf1cd53249716450c0a2
tree 36a1a7d72586a2f8fd25feb225cd4e627cd275b3
parent 735a7ffb739b6efeaeb1e720306ba308eaaeb20e
author Jesper Juhl <[email protected]> 1161984287 +0200 committer Linus Torvalds <[email protected]> 1161988491 -0700

[PATCH] silence 'make xmldocs' warning by adding missing description of 'raw' in nand_base.c:1485

Add description of 'raw' in comments for drivers/mtd/nand/nand_base.c::nand_write_page_syndrome() so 'make xmldocs' will not spew a warning at us.

 drivers/mtd/nand/nand_base.c |    1 +
 1 file changed, 1 insertion(+)
drivers/mtd/nand/nand_base.c +1 -0
index baece61..41bfcae 100644
@@ -1479,6 +1479,7 @@ static void nand_write_page_syndrome(str
  * @buf:     the data to write
  * @page:    page number to write
  * @cached:  cached programming
+ * @raw:     use _raw version of write_page
Quoted 9 lines

drivers/mtd/nand/nand_base.c static void nand_write_page_syndrome(str

Quoted 4 lines
drivers/mtd/nand/nand_base.c +0 -1
  */
 static int nand_write_page(struct mtd_info *mtd, struct nand_chip *chip,
                         const uint8_t *buf, int page, int cached, int raw)
-

Hi Jesper,
I'm still seeing a kernel-doc warning in include/linux/mtd/nand.h. Do you not see it also?

I see it, simply got distracted when doing the patch and forgot about it.

Quoted 3 lines

Patch is here:
http://marc.theaimsgroup.com/?l=linux-mm-commits&m=116189778426861&w=2

Looks good.

Signature · 3 lines
Jesper Juhl <[email protected]>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html