OMAP MMC fixes
PATCH 1/1 OMAP MMC fixes
Hi,
omap mmc driver doesnt use data->blksz_bits anymore in 2619. It uses only data->blksz . Enclosed patch fixes it.
Signed-off-by Marek Vašut <[email protected]>
drivers/mmc/omap.c +3 -3
@@ -633,10 +633,10 @@int sync_dev =0 ; data_addr = host->phys_base +OMAP_MMC_REG_DATA ; - frame =1 << data->blksz_bits; + frame =1 << data->blksz; count =sg_dma_len (sg); -if ((data->blocks ==1 ) && (count > (1 << data->blksz_bits))) +if ((data->blocks ==1 ) && (count > (1 << data->blksz))) count = frame; host->dma_len = count;
@@ -825,7 +825,7 @@ } - block_size =1 << data->blksz_bits; + block_size =1 << data->blksz;OMAP_MMC_WRITE (host,NBLK , data->blocks -1 );OMAP_MMC_WRITE (host,BLEN , block_size -1 );
oops, sorry, I missed the previous patch ...
Dne sobota 28 říjen 2006 20:34 jste napsal(a):
Quoted 5 lines
Hi,
omap mmc driver doesnt usedata->blksz_bitsanymore in 2619. It uses onlydata->blksz. Enclosed patch fixes it.Signed-off-by Marek Vašut <[email protected]>
Quoted 1 line · Marek Vašut
oops, sorry, I missed the previous patch ...
;)
To get it right: You used 1 << data->blksz in your patch. I think it should only be data->blksz without additional shift because shift is already included in data->blksz?
So, do you think
http://linux.omap.com/pipermail/linux-omap-open-source/2006-October/008183.html
is correct?
Thanks
Dirk