taskstats: fix? sk_buff size calculation
PATCH 1/1 taskstats: fix? sk_buff size calculation
Again, I am not sure this patch is correct, it needs an ack...
prepare_reply() adds GENL_HDRLEN to the payload (genlmsg_total_size()), but then it does genlmsg_put()->nlmsg_put(). This means we forget to reserve a room for 'struct nlmsghdr', no?
Signed-off-by Oleg Nesterov <[email protected]>
kernel/taskstats.c renamed from kernel/taskstats.c~2_size +2 -1
@@ -77,7 +77,8 @@ static int prepare_reply(struct genl_inf/* * If new attributes are added, please revisit this allocation */ - skb =nlmsg_new (genlmsg_total_size (size),GFP_KERNEL ); + size =nlmsg_total_size (genlmsg_total_size (size)); + skb =nlmsg_new (size,GFP_KERNEL );if (!skb)return -ENOMEM ;