remove pointless test of task == NULL from i386 dump_trace()
PATCH 1/1 remove pointless test of task == NULL from i386 dump_trace()
In arch/i386/kernel/traps.c::dump_trace() there's a line that reads
if (task && task != current)
but at the start of the function we have
if (!task)
task = current;
So 'task' will never be NULL (since 'current' will never be NULL unless I'm very much mistaken). Which renders the test of 'task == NULL' utter pointless.
Removing the check should provide a microscopic speedup due to a saved cycle or two and in addition it certainly does save a few bytes of .text for traps.o :
before:
text data bss dec hex filename
11887 2284 52 14223 378f arch/i386/kernel/traps.o
after:
text data bss dec hex filename
11871 2284 52 14207 377f arch/i386/kernel/traps.o
---
arch/i386/kernel/traps.c +1 -1
@@ -214,7 +214,7 @@ void dump_trace(struct task_struct *taskif (!stack) {unsigned long dummy; stack = &dummy; -if (task && task != current) +if (task != current) stack = (unsigned long *)task->thread.esp; }