Skip to contentSkip to conversation

don't change cpus_allowed for task initiating the suspend

PATCH New Siddha, Suresh B 1 participant 1 message Nov 2, 2006 CPU hotplug

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 don't change cpus_allowed for task initiating the suspend

Don't modify the cpus_allowed of the task initiating the suspend. _cpu_down() already makes sure that the task doing the suspend doesn't run on dying cpu.

Cc Venkatesh Pallipadi <[email protected]>

---

kernel/cpu.c +1 -5
index 663c920..d21756a 100644
@@ -270,11 +270,7 @@ int disable_nonboot_cpus(void)
 			goto out;
 		}
 	}
-	error = set_cpus_allowed(current, cpumask_of_cpu(first_cpu));
-	if (error) {
-		printk(KERN_ERR "Could not run on CPU%d\n", first_cpu);
-		goto out;
-	}
+
 	/* We take down all of the non-boot CPUs in one shot to avoid races
 	 * with the userspace trying to use the CPU hotplug at the same time
 	 */