Skip to contentSkip to conversation

IPMI: retry messages on certain error returns

PATCH New Corey Minyard 1 participant 1 message Nov 8, 2006 IPMI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 IPMI: retry messages on certain error returns

Some errors more from the IPMI send message command are retryable, but are not being retried by the IPMI code. Make sure they get retried.

Cc Frederic Lelievre <[email protected]>
drivers/char/ipmi/ipmi_msghandler.c +3 -1
Index: linux-2.6.18/drivers/char/ipmi/ipmi_msghandler.c
===================================================================
@@ -3468,7 +3468,9 @@ void ipmi_smi_msg_received(ipmi_smi_t   
                    report the error immediately. */
 		if ((msg->rsp_size >= 3) && (msg->rsp[2] != 0)
 		    && (msg->rsp[2] != IPMI_NODE_BUSY_ERR)
-		    && (msg->rsp[2] != IPMI_LOST_ARBITRATION_ERR))
+		    && (msg->rsp[2] != IPMI_LOST_ARBITRATION_ERR)
+		    && (msg->rsp[2] != IPMI_BUS_ERR)
+		    && (msg->rsp[2] != IPMI_NAK_ON_WRITE_ERR))
 		{
 			int chan = msg->rsp[3] & 0xf;
 
include/linux/ipmi_msgdefs.h +2 -0
Index: linux-2.6.18/include/linux/ipmi_msgdefs.h
===================================================================
@@ -80,6 +80,8 @@
 #define IPMI_INVALID_COMMAND_ERR	0xc1
 #define IPMI_ERR_MSG_TRUNCATED		0xc6
 #define IPMI_LOST_ARBITRATION_ERR	0x81
+#define IPMI_BUS_ERR			0x82
+#define IPMI_NAK_ON_WRITE_ERR		0x83
 #define IPMI_ERR_UNSPECIFIED		0xff
 
 #define IPMI_CHANNEL_PROTOCOL_IPMB	1