Skip to contentSkip to conversation

gitweb: Add an option to href() to return full URL

PATCH New Jakub Narebski 1 participant 1 message Aug 11, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gitweb: Add an option to href() to return full URL

href() subroutine by default generates absolute URL (generated using CGI::url(-absolute=>1), and saved in $my_uri) using $my_uri as base; add an option to generate full URL using $my_url as base.

New feature usage: href(..., -full=>1)

---
This is in preparation for git_rss cleanup (to use href), and further per-branch (per-head) RSS feeds.

 gitweb/gitweb.perl |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
gitweb/gitweb.perl +2 -1
index 8313517..f3fe4bf 100755
@@ -459,7 +459,8 @@ exit;
 
 sub href(%) {
 	my %params = @_;
-	my $href = $my_uri;
+	# default is to use -absolute url() i.e. $my_uri
+	my $href = $params{-full} ? $my_url : $my_uri;
 
 	# XXX: Warning: If you touch this, check the search form for updating,
 	# too.
Signature · 1 line
1.4.3.4